Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller joysticks #412

Closed
wants to merge 0 commits into from
Closed

Conversation

Arman-AIi
Copy link

controllersupport.mp4

@Arman-AIi Arman-AIi marked this pull request as draft November 8, 2024 16:30
@Arman-AIi
Copy link
Author

@ei-pi

@ei-pi
Copy link
Collaborator

ei-pi commented Nov 8, 2024

  1. lint please
  2. should be rebased onto master instead of having a random merge in the middle
  3. see if you can make it not run on rAF (requestAnimationFrame) and have it be event-based instead—running stuff on rAF unnecessarily is just meh

@kenos1
Copy link
Contributor

kenos1 commented Nov 8, 2024

please stop using requestAnimationFrame, Pixi.js Application.ticker exists (go see client/src/scripts/game.ts)

@kenos1
Copy link
Contributor

kenos1 commented Nov 8, 2024

  1. lint please
  2. should be rebased onto master instead of having a random merge in the middle
  3. see if you can make it not run on rAF (requestAnimationFrame) and have it be event-based instead—running stuff on rAF unnecessarily is just meh

Event-based I'm pretty sure is impossible with the web controller API, but that still means you should use better alternatives.

@Arman-AIi
Copy link
Author

@ei-pi

  1. Done
  2. Done, will also do this in the future
  3. It is unfortunately not possible to have gamepad API to be event-based, but I did implement Pixi.js ticker as kenos said

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants