-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update buildings.ts #316
Update buildings.ts #316
Conversation
Update life_preserver.svg
Removed original center lootspawner and added two to the entrances. Removed all small boxes as they cramped the space too much. Readjusted location of ammo crate and applied a 0.97 scale over it to make some space around them. Added a regular crate to the center.
you know you can just push more commits to the same pr |
mb didnt know |
Did you also move and scale the hitboxes of the ammo crates? |
Also why did you remove the boxes |
It looks too messy with them there, I've added two loot spawners to compensate for them |
When I add the sclae property, it adjusts the size and hitboxes of the object, so yes. |
|
The two spawners uses the same loottable as the one that used to be in the center of the warehouse before, i added two to compensate for the removal of the small boxes, also what other crate? |
Farming commits be like |
The boxes that are in the warehouse use the box loot table, whereas you added another warehouse tier spawner which is completely different. Also, there is now a middle box which wasn’t there before. Overall, there’s a lot better loot available now. What’s the reasoning for this change? |
Also that’s an insanely small space between the ammo crate and the wall, even with it scaled down. I don’t think this is gonna work |
Added the center box because I wanted to basically, cuz it felt empty without it, and I didn't know what other tables existed so just used the existing one. @hsanger can edit the spawner loot table if he wishes so. |
nah it's fine, while testing I could move quickly through there, and besides you can destroy the reg crate. |
I don't mind removing the loot spawners. |
If you want the spawner table changed, do it yourself. |
also there shouldn't be a 0.97 size multiplier on the ammo crates if you can help it imo |
Yeah be careful with scaling down stuff cause it messes up the breaking scaling |
I Like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L#371-372 Scaling down is not optimal as it messes with the breaking animation.
Removed scale property on ammo crates in warehouse and loot table adjusted to regular_crate, removed the central reg_crate and moved the ammocrates closer to the centre of warehouse
I've removed scaling, and did some other stuff in my newest commit @Compositr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
If we're going to go with this maybe it could be one of two possible layouts? Randomly either this one or the original. |
lmfao |
Removed original center lootspawner and added two to the entrances.
Removed all small boxes as they cramped the space too much.
Readjusted location of ammo crate and applied a 0.97 scale over it to make some space around them.
Added a regular crate to the center.
Remade PR because I forgot to add the center regular crate.
P.S Check code for errors.