feat: rate limit teams

HasangerGames · Oct 16, 2024 · 532a953 · 532a953
1 parent fc3a030
commit 532a953
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 7 deletions.
diff --git a/server/src/config.ts b/server/src/config.ts
@@ -221,6 +221,11 @@ export interface ConfigType {
          * The list is only reloaded on server startup.
          */
         readonly ipBlocklistURL?: string
+
+        /**
+         * Limits the number of teams that can be created by any one IP address.
+         */
+        readonly maxTeams?: number
     }
 
     /**

diff --git a/server/src/server.ts b/server/src/server.ts
@@ -52,6 +52,8 @@ function removePunishment(ip: string): void {
     }
 }
 
+let teamsCreated: Record<string, number> = {};
+
 export const customTeams: Map<string, CustomTeam> = new Map<string, CustomTeam>();
 
 export let maxTeamSize = typeof Config.maxTeamSize === "number" ? Config.maxTeamSize : Config.maxTeamSize.rotation[0];
@@ -148,19 +150,25 @@ if (isMainThread) {
         upgrade(res, req, context) {
             res.onAborted((): void => { /* Handle errors in WS connection */ });
 
-            const searchParams = new URLSearchParams(req.getQuery());
+            const ip = getIP(res, req);
+            const maxTeams = Config.protection?.maxTeams;
+            if (
+                maxTeamSize === TeamSize.Solo
+                || (maxTeams && teamsCreated[ip] > maxTeams)
+            ) {
+                forbidden(res);
+                return;
+            }
 
+            const searchParams = new URLSearchParams(req.getQuery());
             const teamID = searchParams.get("teamID");
 
             let team!: CustomTeam;
             const noTeamIdGiven = teamID !== null;
             if (
-                maxTeamSize === TeamSize.Solo
-                || (
-                    noTeamIdGiven
-                    // @ts-expect-error cleanest overall way to do this (`undefined` gets filtered out anyways)
-                    && (team = customTeams.get(teamID)) === undefined
-                )
+                noTeamIdGiven
+                // @ts-expect-error cleanest overall way to do this (`undefined` gets filtered out anyways)
+                && (team = customTeams.get(teamID)) === undefined
             ) {
                 forbidden(res);
                 return;
@@ -177,6 +185,10 @@ if (isMainThread) {
                 isLeader = true;
                 team = new CustomTeam();
                 customTeams.set(team.id, team);
+
+                if (Config.protection?.maxTeams) {
+                    teamsCreated[ip] = (teamsCreated[ip] ?? 0) + 1;
+                }
             }
 
             const name = cleanUsername(searchParams.get("name"));
@@ -354,6 +366,8 @@ if (isMainThread) {
                     }
                 }
 
+                teamsCreated = {};
+
                 Logger.log("Reloaded punishment list");
             }, protection.refreshDuration);