Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancing the footer and removing irrelevant items and adding meaningful context, adding a "Rights" section #351

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

shriyadindi
Copy link
Contributor

@shriyadindi shriyadindi commented Oct 31, 2024

πŸ“‹ Description

Enhancing the footer and removing irrelevant items and adding meaningful context, adding a "Rights" section.

issue no.: #348

βœ… Checklist

Research.Nexas.-.Brave.2024-10-31.09-39-23.mp4

Before submitting the PR, please make sure you have completed the following:

  • I have followed all the guidlines mentioned in CONTRIBUTING.md.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation (if applicable).
  • I have tested it locally and it works fine.
  • Any dependent changes have been merged and published in downstream modules.

🏷️ Types of Changes

What type of changes does your code introduce? (Check all that apply)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸŽ‰ Thank you @shriyadindi for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

Copy link
Owner

@Harshdev098 Harshdev098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous one is looking better, what you can do just leave the other section in the footer as usual other than follow us section and copyright is good

don't change these section

Screenshot from 2024-11-01 12-35-51

@shriyadindi
Copy link
Contributor Author

@Harshdev098 I've removed the online shop as it seems to be irrelevant and replaced it with resources, should I keep this change?

@Harshdev098
Copy link
Owner

The content you have removed is ok just keep the layout style

@shriyadindi shriyadindi mentioned this pull request Nov 1, 2024
11 tasks
@shriyadindi
Copy link
Contributor Author

@Harshdev098 I've made the changes and opened a new PR for it, kindly review it.
#361

@Harshdev098 Harshdev098 merged commit ab9d7af into Harshdev098:main Nov 1, 2024
1 check passed
Copy link
Contributor

github-actions bot commented Nov 1, 2024

πŸŽ‰πŸŽ‰ Thank you for your contribution! Your PR #351 has been merged! πŸŽ‰πŸŽ‰

@shriyadindi
Copy link
Contributor Author

@Harshdev098 kindly Assign the labels

@MastanSayyad
Copy link

@Harshdev098 Add labels to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancing the footer and removing irrelevant items and adding meaningful context, adding a "Rights" section
3 participants