overlapping of icons. #314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🎉 Thank you @agarwalbhargavi for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better
|
Its not unnecessary in mobile view it will be helpful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Description
previously the bot and the scroll to top icons were overlapping i have solved the issue.
🔨 Changes Made
instead to doing the plcement of both buttons i deleted the scroll to top button as i feel it was an unnesseary feature ..the reason can seen be through the video attached.as the user can scroll upwards by using the buttons in navbar
Recording.2024-10-26.224140.mp4
✅ Checklist
Before submitting the PR, please make sure you have completed the following:
I have followed all the guidlines mentioned in CONTRIBUTING.md.
My code follows the style guidelines of this project.
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
I have made corresponding changes to the documentation (if applicable).
I have tested it locally and it works fine.
Any dependent changes have been merged and published in downstream modules.
Fixes overlapping of icons. #298
@Harshdev098 kindly review and merge my PR into the main with all the relevant tags.