Add map methods #21
Merged
Add map methods #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are several methods that can be used to create a new `Array2D`. In the past, these have typically had the "source" (iterator, generator function, etc.) first, followed by the dimensions. However, this can make the source code somewhat awkward if, for example, you use a closure the ends up being moderately large. These functions now put the dimensions first, which makes the "source" parameter last.
Previously, the only way to create a new `Array2D` was to either manually specify both the source and size of the array or to provide preexisting rows/columns. However, it is common to want to create a new array from the contents of a previously existing array. The new `map_*` methods allow the user to provide a "mapping" function that transforms the elements of the existing array into new elements for the new array. There are "row major" and "column major" versions of these methods. The differences will not be relevant unless the provided "mapping" function is modifying shared state. See the test cases that modify a "counter" variable (`mutable_counter`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the only way to create a new
Array2Dwas to either manually specify both the source and size of the array or to provide preexisting rows/columns. However, it is common to want to create a new array from the contents of a previously existing array.The new
map_*methods allow the user to provide a "mapping" function that transforms the elements of the existing array into new elements for the new array.There are "row major" and "column major" versions of these methods. The differences will not be relevant unless the provided "mapping" function is modifying shared state. See the test cases that modify a "counter" variable (
mutable_counter).