Introduce in-game Randomizer Settings menu, remove plando mode #4804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aMannus
commented
Jan 4, 2025
Comment on lines
+270
to
+272
| void ShowRandomizerSettingsMenu() { | ||
| mRandomizerSettingsWindow->Show(); | ||
| } |
There was a problem hiding this comment.
I'm not very happy with this living inside SohGui.cpp but I've tried to extern the window pointer in other places and just couldn't get it to work. If someone has any other options I'm all ears.
Malkierian
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new in-game menu after selecting randomizer in the quest select screen, where players can generate a new randomizer seed in-game (with their currently selected settings) as a replacement for the plando mode introduced a while back.
This menu could be expanded down the line to select already existing seeds etc, but for now we just needed a replacement for plando mode that's more UX friendly.
I'd love to get some testing on this to make sure dropping spoilers on the game window and if generating new seeds works as expected now, as rando generation as is, is quite confusing.
Looks like this:
https://github.com/user-attachments/assets/47d16955-3f61-4f55-83fb-96d894914cce
Build Artifacts