Alt Asset Preload and Persistence (aka "Error 404: Asset Load Hiccup Not Found") #4652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briaguya-ai
reviewed
Dec 9, 2024
briaguya-ai
approved these changes
Dec 9, 2024
|
Fixed an issue that was causing the game to unload the scene it was going into if it was a back and forth (otherwise just lagging behind by a scene), but I'm marking this as do not merge as I want to try to refine the persistence to cut down on memory usage. |
|
Now requires Kenix3/libultraship#752 before I can remove do not merge, but dynamic skybox loading and unloading is done. Reloaded 4K is now buttery smooth, and for me never got above 6GB of RAM usage thanks to the skybox tweaks. |
Malkierian
force-pushed
the
alt-asset-bulk-preload
branch
from
f6c8afa to
a8ca475
Compare
|
Of course, ymmv, since the preload time might not be enough on lower-end machines, but should still improve things quite a bit. |
Malkierian
force-pushed
the
alt-asset-bulk-preload
branch
from
a055119 to
ea697d8
Compare
Malkierian
force-pushed
the
alt-asset-bulk-preload
branch
from
ea697d8 to
9abd8f4
Compare
This was referenced Dec 19, 2024
Archez
reviewed
Dec 28, 2024
Merged
Archez
reviewed
Jan 3, 2025
… some persistent alt asset loading. Utilizes threading to handle LUS directory load and unload filtering.
Add comment documentation. Refine a little persistent preload.
Un-persist skybox textures, add dynamic skybox loading instead.
…namic skybox loading and unloading.
Update for related LUS PR changes, which includes removing the threading (will be re-implemented when LUS Context thread pool access is added).
… functions to prevent debug stutter on transition.
Malkierian
force-pushed
the
alt-asset-bulk-preload
branch
from
6d8ff03 to
fec6765
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds alt asset preloading to the flow, as well as some common-sense alt asset persistence (menus, effects, audio, skyboxes). This altogether eliminates the asset load hitch that alt asset mods commonly suffer from except in a very few specific circumstances.
This all now runs in the background, whether alt assets are enabled or not, with no adverse effects on performance aside from the continued higher memory usage.
This does make it load a lot more assets in the persistent manner, so when using the 4K pack, usage can be 8GB+ on a continual basis, but I'm sure the 4K users would prefer to have that with virtually no hiccups rather than lower memory usage. Obviously, the usage will be significantly lower with standard HD packs.
This has the following effects (demonstrated with OoT Reloaded 4K to properly showcase the capabilities): audio on!
Startup is significantly faster when loading with alt assets enabled, and the logo, transitions, and sound effects all load without issues.
Before:
D1bH8KI.mp4
After:
D08Qoms.mp4
Loading directly into a save file is also still significantly smoother:
Before:
Q2n1SOs.mp4
After:
haZQNZk.mp4
Loading into file select is faster and smoother, and there are no skybox load hiccups
Before:
0nEHNKn.mp4
After:
JFJWmiu.mp4
The pause menu, and visual effects, give no hitches on first load, even across transitions
Before:
5FUaPaj.mp4
After:
JY0XLJJ.mp4
Reset loads are blazing fast
Before:
HNgH4DP.mp4
After:
zGaGtIY.mp4
And finally, the transition hitches are virtually eliminated, only being noticeable when loading areas like Hyrule Field, and toggling alt assets on in new areas takes almost no time at all:
Before:
d7NYTVO.mp4
After:
3YREvQj.mp4
Build Artifacts