Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Better SoDT to work on Night of the Final Day #913

Merged
merged 8 commits into from
Jan 3, 2025

Conversation

zodiac-ill
Copy link
Contributor

@zodiac-ill zodiac-ill commented Dec 31, 2024

Ordinarily, Song of Double Time does not work on Night of the Final Day in vanilla as you cannot advance any farther. This makes sense in vanilla, but Better SoDT users may want to advance time within Night of the Final Day.

Build Artifacts

Copy link
Contributor

@garrettjoecox garrettjoecox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Been meaning to get to this, would you mind changing the VB to be more descriptive then this LGTM! (something like VB_ALLOW_SONG_DOUBLE_TIME_ON_FINAL_NIGHT)

@zodiac-ill
Copy link
Contributor Author

Nice! Been meaning to get to this, would you mind changing the VB to be more descriptive then this LGTM! (something like VB_ALLOW_SONG_DOUBLE_TIME_ON_FINAL_NIGHT)

Got it!

mm/src/code/z_message.c Outdated Show resolved Hide resolved
@garrettjoecox garrettjoecox merged commit 0d1186b into HarbourMasters:develop Jan 3, 2025
5 checks passed
@zodiac-ill zodiac-ill deleted the sodt-patch-1 branch January 4, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants