Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unique message id to requests/responses #56

Merged
merged 2 commits into from
May 18, 2024
Merged

Add unique message id to requests/responses #56

merged 2 commits into from
May 18, 2024

Conversation

benthecarman
Copy link
Contributor

Closes #48

@benthecarman benthecarman requested a review from TonyGiorgio May 17, 2024 19:39
TonyGiorgio
TonyGiorgio suggested changes May 17, 2024
View reviewed changes
src/bridge.rs Outdated Show resolved Hide resolved
src/bridge.rs Outdated Show resolved Hide resolved
src/bridge.rs Outdated Show resolved Hide resolved
@benthecarman
Copy link
Contributor Author

Hooked it up for sends and receives and it works!

Can test by :

  1. generate invoice
  2. save for later
  3. generate new invoice
  4. pay first invoice
  5. should not go to success screen
  6. pay new invoice
  7. it does go to success screen

futurepaul
futurepaul approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@futurepaul futurepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me!

TonyGiorgio
TonyGiorgio approved these changes May 18, 2024
View reviewed changes
Copy link
Contributor

@TonyGiorgio TonyGiorgio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aweomse work

@TonyGiorgio TonyGiorgio merged commit dcb119a into master May 18, 2024
2 checks passed
@TonyGiorgio TonyGiorgio deleted the msg-id branch May 18, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonyGiorgio TonyGiorgio TonyGiorgio approved these changes

@futurepaul futurepaul futurepaul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add message ID to all actions
3 participants
@benthecarman @futurepaul @TonyGiorgio