Do some of the todos #102
Merged
Do some of the todos #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
commented
Nov 24, 2024
| @@ -737,7 +742,6 @@ impl HarborWallet { | |||
| _ => "Unknown".to_string(), | |||
| }; | |||
|
|
|||
| // TODO: what to do about balance in this case? Maybe it should be Option<u64>? | |||
There was a problem hiding this comment.
we didnt need the balance here
futurepaul
requested changes
Nov 24, 2024
| @@ -1,4 +1,4 @@ | |||
| /target | |||
There was a problem hiding this comment.
on my system running just run from the root dir still creates a target dir in the root. so maybe we need /target and */target?
| match self.send_amount_input_str.parse::<u64>() { | ||
| Ok(amount) => Some(amount), | ||
| Err(e) => { | ||
| eprintln!("Error parsing amount: {e}"); |
There was a problem hiding this comment.
nice I can show a toast for these parse fails. I also need to fix the amount input so you can only type numbers
There was a problem hiding this comment.
I also need to fix the amount input so you can only type numbers
i tried to do this but couldnt figure it out
futurepaul
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.