This repository has been archived by the owner on Jun 1, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 346
Automatically hide read posts on Reddit #3146
Open
bobobo1618
wants to merge
132
commits into
Haptic-Apps:master
Choose a base branch
from
bobobo1618:hideonreddit
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So the first thing we'd need to look at befor considering a merge like this is, as you said a toggle. This tech might also be able to be used with Synccit to ensure that seen posts are hidden. It's a good idea but realistically, we'd need to see a toggle before we could consider the PR. |
(Finally) added a toggle. |
Optimize PNGs throughout the project
Replace deprecated Html#fromHtml with HtmlCompat#fromHtml
Fix app tints to please lint
…RenameOption Fixes Haptic-Apps#3187 by hiding option to rename multireddit
Collapse deleted and removed comments by default Haptic-Apps#2951
Fixes Haptic-Apps#3185: AlertDialog gives option to save multireddit upon exiting
This reverts commit 5e94e1e (Reason: Some icons are acting up with shading and not shading, this is temporary)
Add settings to hide awards
…migration Fix gifdeliverynetwork redirection
…-stuck Fixes notification getting stuck on 'downloading' after a sucessful download
…ed into the Reddit redesign, Fixed RGB_8888 on SubsamplingScaleImageView
… into ZianeA-3035-saved-image-name
…o-logsub-crash Fix crash when toolbox config doesn't have values
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #3119.
When a user scrolls past a post, it is added to an in-memory queue of posts waiting to be hidden. Whenever the user performs an action that would load more posts (like switching subreddits or scrolling some more), all of the posts in the queue are hidden server-side and the queue is empty.
This ensures that a user will only ever see the same post once.
I also tried to make the code I was touching a little bit cleaner.
I'm not very experienced with Java so let me know if my code is terrible.
This is intended to be a starting point, I don't expect anything to be merged right away. There isn't even an option to toggle this behaviour yet.