This repository has been archived by the owner on Jun 1, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 346
Multireddit dropdown list in drawer #3066
Open
philippTheCat
wants to merge
2
commits into
Haptic-Apps:master
Choose a base branch
from
philippTheCat:feature/multireddit_dropdown
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Multireddit dropdown list in drawer #3066
philippTheCat
wants to merge
2
commits into
Haptic-Apps:master
from
philippTheCat:feature/multireddit_dropdown
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexendoo
suggested changes
Sep 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Particular thanks for being brave enough to touch MainActivity
app/src/main/java/me/ccrama/redditslide/Activities/MainActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/me/ccrama/redditslide/Activities/MainActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/me/ccrama/redditslide/Activities/MainActivity.java
Outdated
Show resolved
Hide resolved
philippTheCat
force-pushed
the
feature/multireddit_dropdown
branch
from
September 18, 2019 11:09
9ffac05
to
b99f08a
Compare
Alexendoo
suggested changes
Sep 18, 2019
headerMain = header; | ||
hea = header.findViewById(R.id.back); | ||
|
||
drawerSubList.addHeaderView(header, null, false); | ||
((TextView) header.findViewById(R.id.name)).setText(Authentication.name); | ||
header.findViewById(R.id.multi).setOnClickListener(new OnSingleClickListener() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this removed it's not possible to open the regular MultiredditOverview
Alexendoo
reviewed
Sep 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A final appearance thing, but you might also want to hide the dropdown if the user doesn't have any multireddits, since it still toggles but nothing appears underneath
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.