Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

Multireddit dropdown list in drawer #3066

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

philippTheCat
Copy link

No description provided.

Copy link
Member

@Alexendoo Alexendoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Particular thanks for being brave enough to touch MainActivity

app/src/main/res/layout/drawer_loggedin.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/drawer_loggedin.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/drawer_loggedin.xml Outdated Show resolved Hide resolved
@philippTheCat philippTheCat force-pushed the feature/multireddit_dropdown branch from 9ffac05 to b99f08a Compare September 18, 2019 11:09
headerMain = header;
hea = header.findViewById(R.id.back);

drawerSubList.addHeaderView(header, null, false);
((TextView) header.findViewById(R.id.name)).setText(Authentication.name);
header.findViewById(R.id.multi).setOnClickListener(new OnSingleClickListener() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this removed it's not possible to open the regular MultiredditOverview

Copy link
Member

@Alexendoo Alexendoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A final appearance thing, but you might also want to hide the dropdown if the user doesn't have any multireddits, since it still toggles but nothing appears underneath

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants