Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a way to know if our .env file should be updated #11

Closed
DuaelFr opened this issue Mar 1, 2019 · 2 comments
Closed

Implement a way to know if our .env file should be updated #11

DuaelFr opened this issue Mar 1, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@DuaelFr
Copy link
Contributor

DuaelFr commented Mar 1, 2019

Sometimes, we need to add project specific variables to the settings.sh/.combawa file.
In this scenario, a person that would pull a new version of this file could not know that they have to update their .env file accordingly.

Proposed solution: add a COMBAWA_SCHEMA variable which value is 1 by default in both settings.sh/.combawa and .env files. In the prerequisites, check that these numbers are equal.

Do not forget to document this change in the readme
@DuaelFr DuaelFr added the enhancement New feature or request label Mar 1, 2019
@Artusamak Artusamak mentioned this issue Mar 1, 2019
Open
@Artusamak
Copy link
Contributor

Duplicates #9 ? ;)

@Artusamak Artusamak mentioned this issue Mar 29, 2019
Closed
@DuaelFr
Copy link
Contributor Author

DuaelFr commented Jul 28, 2020

Closed as duplicate

@DuaelFr DuaelFr closed this as completed Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Artusamak @DuaelFr