Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency to npm #7

Closed
Artusamak opened this issue Feb 28, 2019 · 4 comments
Closed

Remove dependency to npm #7

Artusamak opened this issue Feb 28, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@Artusamak
Copy link
Contributor

Having to require NPM in the build process is probably not a good idea if you operate with a lightweight process or wants to build just the prod sites. Requiring NPM to build the CSS is overkilled. Just being able to plug to it if you want to compile the theme seems like a smoother approach.
@Artusamak Artusamak added the enhancement New feature or request label Feb 28, 2019
DuaelFr pushed a commit that referenced this issue Feb 28, 2019
Issue #7: remove npm dependency.
93d82ef 
Change-Id: Id2e491b17ef1af822379b724b53827ff2b622901
@DuaelFr
Copy link
Contributor

DuaelFr commented Feb 28, 2019

Npm dependency has been removed.
Npm builds should to be ran out of combawa from now.

@DuaelFr DuaelFr closed this as completed Feb 28, 2019
@Artusamak
Copy link
Contributor Author

It's a good start but it lacks a documentation for actual installations i think. I could throw a curse word like BC but i won't =).

@Artusamak Artusamak reopened this Feb 28, 2019
@Artusamak
Copy link
Contributor Author

#11

@DuaelFr
Copy link
Contributor

DuaelFr commented Jul 28, 2020

To be discussed in #9

@DuaelFr DuaelFr closed this as completed Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Artusamak @DuaelFr