-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add oceanBottomPressure eov #407
base: master
Are you sure you want to change the base?
Conversation
this is related to #406 |
I think there are more spots the EOV is referenced in the codebase. If you do a search through the entire codebase for an existing EOV, eg |
I think this is integrating all the different places where oceanBottomPressure should be added. I'll review if the deployment is complaining or not |
By deployment do you mean see if it works after deployed to the live site? It would be great to test this PR in a development environment |
oh sorry I meant locally |
… which isn't there anymore
@n-a-t-e I successfully deployed this latest PR locally and did see the new EOV available via the UI. I think we're good to go. Just maybe approuve it and then we can see how to update the production deployment of CDE with those latest changes. |
40d61a0
to
cb9eb58
Compare
Push development branch to explore-cioos
Add ocean Bottom pressure eov to cde as requested by ONC.
See goose eov for more details.
I'm not sure if there's more needed. I'm also not sure if the
sea-level.svg
icon is the appropriate one for it. Though those icons do not seem to be stored within this repo.