[core] Restored logger perf improvements that were blocked up to 1.6.0 #2900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethouris
added
Type: Maintenance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2900 +/- ##
==========================================
- Coverage 64.72% 64.64% -0.08%
==========================================
Files 101 101
Lines 17543 17541 -2
==========================================
- Hits 11355 11340 -15
- Misses 6188 6201 +13 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the performance improvements in the logging system.
This time any modification of the logger configuration is updated immediately in all loggers. Therefore the
CheckEnabled()function, which is called every time a log has to be printed (no matter if it's going to be printed or not), this time just returns a boolean flag. This flag is kept in sync with the configuration, but only at the time when the configuration is changed.