Merge saving game state #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humdingerb
reviewed
Mar 30, 2024
Game.cpp
Outdated
| bool loadOK = true; | ||
|
|
||
| for(int i =0;i<fSizeX*fSizeY;i++) { | ||
| loadOK = loadOK && saveMessage.FindUInt32("board",i,&fBoard[i]) == B_OK; |
There was a problem hiding this comment.
I'm tiring adding all those spaces... :)
Below, also add a space before commas etc.
|
Two things I found:
|
humdingerb
reviewed
Apr 1, 2024
Game.cpp
Outdated
|
|
||
| BMessage saveMessage(H2048_SAVE_MESSAGE); | ||
| status_t result = saveMessage.Unflatten(&saveFile); | ||
| if(result!= B_OK) { | ||
| if (result != B_OK) | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Missed the closing curly bracket.
dospuntos
force-pushed
the
merge-saving-game-state
branch
from
24b50bb
to
84a2e75
Compare
|
Very good. Merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to complete a previous PR (#26 ) by fixing the comments on coding style. The original code seems to work great otherwise, and the game state and window position is saved when exiting the game.
Please let me know if there still are discrepancies in the coding style.