Changed gen_metadata to work for requests with post_processors #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe this fix is correct, but I don't have a local version I can easily test with.
|
@tazlin I'm incapable of testing this right now. Can you have a look? |
|
Superceded via #298. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fix is correct, but I don't have a local version I can easily test with.
I also don't know enough about the underlying system to know if there are any side-effects caused by this...
But generally speaking, it looks like each image runs the post_processors and stores the gen_metadata for those in the variable single_image_faults. But we previously could have already had faults from bad LoRAs or other reasons. Those were getting lost and replaced by the list of post_processor messages.