Fix an error that may occur shortly after worker replacement #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a worker is brand new, sometimes in start_inference() the VRAM model eviction might compare against HordeProcessInfo.last_control_flag and discover that there is no such property. ... and that's how I discovered the field declarations at the top of classes are just documentation, and you still need to assign something in the constructor.
Avoids uses the dataclass/pydantic way of relying on class members to set defaults for `HordeProcessInfo` (which is not a dataclass or pydantic BaseModel).
tazlin
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
I've moved the other default values for HordeProcessInfo to the __init__(...) for consistency. Default member values are bound to the class type and while I tend to feel that aliasing the class member with a value of None (or other defaults) with instance versions of those members is not a big deal, having the default definition in __init__(...) does better represent that these are instance variables.
|
Oh, I see the mistake I made. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a worker is brand new, sometimes in start_inference() the VRAM model eviction might compare against
HordeProcessInfo.last_control_flag and discover that there is no such property.
... and that's how I discovered the field declarations at the top of classes are just documentation, and you still need to assign something in the constructor.