Go fast fix minor #360
Merged
Go fast fix minor #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This needs to be empty for the auto detect logic to work
HPPinata
force-pushed
the
go-fast-fix-minor
branch
from
e93dedc to
dda98df
Compare
|
@tazlin could you take a look at this? It's fixing a couple small but annoying oversights, currently preventing the main branch from working properly on non flash_attn GPUs (at least in docker). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some small logical oversights after updating the compatibility check and including cleanup in case flash_attn is later removed. We don't want to manually overwrite the compatibility check in the
compose.yamlby default.Also, without
rm -fDocker doesn't wanna start ifFLASH_ATTN=FALSE, because technically anrmon a non existant file is an unsuccessful command.Split out from #358, since that is more complex and requires some extra testing.