Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't fail on seed 0 during job submit #94

Merged
merged 1 commit into from
Dec 14, 2023
Merged

fix: don't fail on seed 0 during job submit #94

merged 1 commit into from
Dec 14, 2023

Conversation

tazlin
Copy link
Member

@tazlin tazlin commented Dec 14, 2023

  • This changes the log message for when 0 is set as the seed in a submit payload to a DEBUG level message.
  • As seen in comfyui, 0 is a valid value, and assuming the end user actually specified it, the SDK shouldn't be logging an error in this situation.
  • However, of the 2^64 allowed values, 0 is awfully specific, so I will continue logging a debug level message to track potential problems (such as default ints (0) being used inadvertently).

@tazlin tazlin merged commit fc419ca into main Dec 14, 2023
2 checks passed
@tazlin tazlin deleted the seed-0 branch December 26, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant