Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adds worker_details_by_name #247

Merged
merged 5 commits into from
Sep 17, 2024
Merged

feat: Adds worker_details_by_name #247

merged 5 commits into from
Sep 17, 2024

Conversation

db0
Copy link
Member

@db0 db0 commented Sep 15, 2024

How does this look?

@db0 db0 requested a review from tazlin September 15, 2024 13:34
tazlin and others added 5 commits September 17, 2024 11:04
@tazlin
fix: compat. hack for users/get/200
8073254 
The api doc that corresponds to `_v2_users_get_200.json` is inaccurate. For the time being I am avoiding updating the API itself as it may create unanticipated problems. This simply coerces the automatically generated json file to be an array if it is not already.
@db0 @tazlin
feat: worker details by name
9bb97ea
@tazlin
fix: add apikey arg to 'simple clients' worker funcs, update example
97ca95e
@tazlin
docs: note to run build_docs.py in CONTRIB.md
d591178
@tazlin
docs: note object_verify tests and purpose
d97fd39
tazlin
tazlin approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@tazlin tazlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed elsewhere, path data should be defined in the appropriate metadata.py. The path values (e.g., worker_id or now worker_name) are handled magically at submit time.

@tazlin tazlin merged commit 409e3d0 into main Sep 17, 2024
4 checks passed
@tazlin tazlin mentioned this pull request Sep 17, 2024
Merged
@db0 db0 deleted the worker_name2 branch September 20, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tazlin tazlin tazlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@db0 @tazlin