fix: rc field support for RequestErrorResponse; feat: better __eq__ and __hash__ implementations where appropriate
#143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted at https://github.com/Haidra-Org/horde-worker-reGen/blob/976cd0f20acaacd0d20d24c275ad6bff29e79ace/horde_worker_regen/process_management/process_manager.py#L1371, there is merit to having SDK objects be hashable (and therefore usable as keys in dicts/sets).
Updates the requirements on [horde-model-reference](https://github.com/Haidra-Org/horde-model-reference), [pytest](https://github.com/pytest-dev/pytest), [black](https://github.com/psf/black), [ruff](https://github.com/astral-sh/ruff) and [pre-commit](https://github.com/pre-commit/pre-commit) to permit the latest version. Updates `horde-model-reference` to 0.5.4 - [Commits](Haidra-Org/horde-model-reference@v0.5.4...v0.5.4) Updates `pytest` from 7.4.4 to 8.0.0 - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest@7.4.4...8.0.0) Updates `black` from 23.12.1 to 24.2.0 - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](psf/black@23.12.1...24.2.0) Updates `ruff` from 0.1.14 to 0.2.1 - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](astral-sh/ruff@v0.1.14...v0.2.1) Updates `pre-commit` to 3.6.1 - [Release notes](https://github.com/pre-commit/pre-commit/releases) - [Changelog](https://github.com/pre-commit/pre-commit/blob/main/CHANGELOG.md) - [Commits](pre-commit/pre-commit@v3.6.0...v3.6.1) --- updated-dependencies: - dependency-name: horde-model-reference dependency-type: direct:production dependency-group: python-packages - dependency-name: pytest dependency-type: direct:development update-type: version-update:semver-major dependency-group: python-packages - dependency-name: black dependency-type: direct:development update-type: version-update:semver-major dependency-group: python-packages - dependency-name: ruff dependency-type: direct:development update-type: version-update:semver-minor dependency-group: python-packages - dependency-name: pre-commit dependency-type: direct:development dependency-group: python-packages ... Signed-off-by: dependabot[bot] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RequestErrorResponseobjects, fixing a very apparent issue surrounding this seen in the worker.__eq__and__hash__) have been added where appropriate to facilitate comparison and to allow using certain SDK objects as keys forHordeAPIDataObjectinstead ofpydantic.BaseModeldirectly.dicts(or other mappings).