-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expression Language support #1654
base: master
Are you sure you want to change the base?
Conversation
2aea320
to
2e248f5
Compare
I had the same idea in mind a while ago. But since it's time consuming i didn't start working on it. Sounds good! 👍 Is it possible to (auto-)inject it inside DocTags and/or PHP8 attributes? |
Thank you for feedback @King2500!
Yes, I think it's possible. I will go through symfony documentation and try identify all possible spots before moving PR from draft to "Ready for review" state. |
efc97a8
to
16bbbdd
Compare
78b7cd8
to
3aa43aa
Compare
774e536
to
1347346
Compare
5cc0e30
to
6133ea9
Compare
98daa78
to
5464605
Compare
5464605
to
14afd15
Compare
44eba02
to
e5b4001
Compare
Added support for Expression Language component (https://symfony.com/doc/current/components/expression_language.html)
TODO
Auto inject expression language into:
\Symfony\Component\ExpressionLanguage\ExpressionLanguage::{evaluate,compile,parse}
\Symfony\Component\ExpressionLanguage\Expression::__construct
https://symfony.com/doc/current/reference/twig_reference.html#expressionMissing PsiLanguageInjectionHost impl. on TwigCompositeElement
Note for reviewers
Expression Language parser
fr.adrienbrault.idea.symfony2plugin.expressionLanguage
packageExpressionLanguage.bnf
andExpressionLanguage.flex
files as part of the plugin build process using https://github.com/JetBrains/gradle-grammar-kit-pluginLanguage Injections
fr.adrienbrault.idea.symfony2plugin.lang.ParameterLanguageInjector
in favour offr.adrienbrault.idea.symfony2plugin.lang.StringLiteralLanguageInjector
StringLiteralLanguageInjector
allows inject language into string literals used in various contexts: Attributes, Annotations, Constructor/Function/Method call argument, Variable assigment and also takes into account named arguments introduced in PHP 8YamlLanguageInjector
/XmlLanguageInjector
Links