Set build mode to Release in hwlocality-sys #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 1 of 1 files.
|
|
Makes sense. Thanks for the contribution! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
==========================================
- Coverage 82.97% 82.92% -0.06%
==========================================
Files 44 44
Lines 5134 5135 +1
==========================================
- Hits 4260 4258 -2
- Misses 874 877 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Looks like the libm indirect dependency silently bumped its MSRV and this is what causes the build failure. I'll look into it. |
|
This was accidental and fixed in libm 0.2.10, so simply re-running the CI job should do the trick. Let's try that... |
HadrienG2
added a commit
that referenced
this pull request
Oct 28, 2024
This will avoid future occurences of unseen MSRV breakage as in #158, at the expense of requiring more everyday dependabot ceremony. For this particular project, I think the tradeoff is worthwhile.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change on
vandoredbuild hwlocality for windows platform. This set the profile for the cmake on windows toRelease. It will ensure that there is no debug logs being written to the stdout when running the library.