Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete config_interaction.h #440

Merged
merged 3 commits into from
Jul 22, 2022
Merged

Delete config_interaction.h #440

merged 3 commits into from
Jul 22, 2022

Conversation

Reonu
Copy link
Contributor

@Reonu Reonu commented Jun 29, 2022

Fixes #435

@Reonu Reonu added the enhancement New feature or request label Jun 29, 2022
@Reonu Reonu added this to the 2.1 milestone Jun 29, 2022
@Reonu Reonu requested a review from Mr-Wiseguy as a code owner June 29, 2022 16:28
@Reonu Reonu self-assigned this Jun 29, 2022
@Arceveti Arceveti linked an issue Jul 19, 2022 that may be closed by this pull request
Remove config define bloat #436
Open
@Arceveti Arceveti removed a link to an issue Jul 19, 2022
Remove config define bloat #436
Open
@Arceveti Arceveti linked an issue Jul 19, 2022 that may be closed by this pull request
Remove config_interactions.h file, move the one define it has somewhere else #435
Closed
Arceveti
Arceveti approved these changes Jul 19, 2022
View reviewed changes
Copy link
Collaborator

@Arceveti Arceveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arthurtilly
Copy link
Collaborator

based

@thecozies
Copy link
Contributor

@Reonu conflicts it needs has resolved help aaaaaaaa

@Reonu
Copy link
Contributor Author

Reonu commented Jul 19, 2022

@thecozies

@Reonu Reonu requested a review from thecozies July 19, 2022 13:37
@gheskett gheskett removed this from the 2.1 milestone Jul 21, 2022
@gheskett gheskett added this to the 2.1 milestone Jul 21, 2022
@thecozies thecozies merged commit 77f4bec into develop/2.1.0 Jul 22, 2022
@thecozies thecozies deleted the develop/reonu/2.1.0_delete_config_interaction.h branch July 22, 2022 14:20
WSLUser added a commit to WSLUser/HackerSM64 that referenced this pull request Aug 22, 2022
@WSLUser @gheskett
@aglab2 @FazanaJ @axollyon @Mr-Wiseguy @Arceveti @Reonu @arthurtilly @thecozies @Tubular-Bells
Develop/2.1.0 (#2)
0092e07 
* Deprecate sBackgroundMusicDefaultVolume

* Add MAX_SIMULTANEOUS_NOTES defines and better document audio allocations for audio heap (looks kinda awful still)

* Some formatting changes :( (But also some safeguards and updated documentation)

* Pointless memory allocation

* Audio safeguard error

* Bugfix: the smaller MAX_SIMULTANEOUS_NOTES define, when used, can lead to silence on audio init

* Bugfixes, sound bank heap defines, BETTER_REVERB improvements

* Whoops

* sAudioFirstBoot renamed to sAudioIsInitialized

* Added no cap music restarts define (HackerN64#335)

* Add missing syncs for G_PM_NPRIMITIVE (HackerN64#345)

* Fixed eeprom saving on VC (HackerN64#334)

* Fixed eeprom saving on VC

* Specify SM for EEP4K, for any other savetype use ED

* Moved IS_VC() check to an earlier point, switch IS_VC()->gIsVC

* Moved binary VC files to bin folder, added checks for EEP

* Do not keep vc_bin if EEP is not set

* Added buttonReleased member in the controller struct (HackerN64#421)

* Bugfix, refactor, and slightly improve BETTER_REVERB runtime (HackerN64#391)

* Buxfix, refactor, and slightly improve BETTER_REVERB runtime

* Update BETTER_REVERB defaults and add some more customizability

* Improve BETTER_REVERB runtime even further

* Rename some reverb variables to make more sense in context

* Suppress a gcc10 compiler warning for uninitialized variable

* Adjust the static surface pool's size automatically per level and add static object collision (HackerN64#444)

* Fixed function addresses being incorrect in crash screen stacktrace (HackerN64#333)

* Clear only used dynamic cells (HackerN64#451)

Clear only used dynamic cells

* Fixed memory leak between areas from automatic surface pool size (HackerN64#452)

* fixed mem leak

* Add comment to second pop

* Mat Stack Fix

* Implemented new lightweight CPU/RDP profiler
* Added RSP profiling to the lightweight profiler
* Added CPU audio to lightweight profiler
* Changed lingering manual light struct definitions to gdSPDefLights1, made a dummy light for Koopa's pink shorts
* Ran script to convert all light commands to lightcolor commands
* Added define guards for the profiler
* Wrote function for setting up global light direction in the frame
* Moved camera matrix into projection stack
* Corrected cameraToObject for the new matrix stack (fixes culling and sound)
* Fixed billboarding with new matrix stack
* Fixed shadows with new matrix stack
* Fixed some areas where the game was previously extracting the camera matrix from various matrices
* Restored vanilla light and env map directions under new matrix stack
* Fix goddard crash
* Fix geo_process_level_of_detail
* Remove 'construct_float' from 'geo_process_level_of_detail'
* Removed some accidentally added files
* Removed unnecessary matrix multiplications in geo_process_object
* Added fixlights script to build system for fixing custom assets and added option to disable it if needed
* Fixed visual debug with new matstack and cleaned up visual debug code
* Fixed handling of WORLD_SCALE in view matrix so it doesn't get cancelled out
* Fixed clip planes not scaling based on WORLD_SCALE

Co-authored-by: Mr-Wiseguy <[email protected]>
Co-authored-by: Arceveti <[email protected]>
Co-authored-by: thecozies <[email protected]>

* moved CASTLE_MUSIC_FIX into level specific checks (HackerN64#437)

* Clean up gotos from find_wall_collisions_from_list (HackerN64#288)

* Replace unused 0C bank with aglab's / scut's extended 0C bank  (HackerN64#412)

* Delete config_interaction.h (HackerN64#440)

* Line endings for all text files now forced to \n instead of \r\n (HackerN64#464)

* Reformat config comments (HackerN64#470)

* fix level mesh not updating (HackerN64#477)

Co-authored-by: gheskett <[email protected]>
Co-authored-by: Denis Kopyrin <[email protected]>
Co-authored-by: Fazana <[email protected]>
Co-authored-by: axollyon <[email protected]>
Co-authored-by: Mr-Wiseguy <[email protected]>
Co-authored-by: Arceveti <[email protected]>
Co-authored-by: Reonu <[email protected]>
Co-authored-by: arthurtilly <[email protected]>
Co-authored-by: thecozies <[email protected]>
Co-authored-by: thecozies <[email protected]>
Co-authored-by: Arceveti <[email protected]>
Co-authored-by: Tubular Bells <[email protected]>
FazanaJ added a commit to FazanaJ/HackerSM64 that referenced this pull request Dec 14, 2022
@FazanaJ
Squashed commit of the following:
c6b0120 
commit 9bec16d
Author: someone2639 <[email protected]>
Date:   Tue Dec 13 15:55:31 2022 -0500

    rendering_graph_node layer table updated with gcc extensions for legibility (HackerN64#467)

    * rendering_graph_node layer table updated with gcc extensions for legibility

    * side effect removed

    Co-authored-by: someone2639 <[email protected]>

commit 8043823
Author: Arceveti <[email protected]>
Date:   Mon Dec 12 14:40:55 2022 -0500

    Merge master/2.0.8 into 2.1.0 (HackerN64#551)

    * Imminent fixes for bugs found on master branch (HackerN64#512)

    * The vanilla level checks define for Yoshi is inverted, causing him to require 120 stars when it is off and appear at 0 stars when it's on

    *  The downwarp fix results in Mario levitating in midair when grabbing Bowser midair. While downwarps should still be fixed, the change should be reverted immediately until a better fix is made.

    *  Some checks of Mario's floor class were using the wrong defines, which can lead to unexpected behavior in the event anyone wants to reorder surface types. By default the SURFACE_CLASS_SLIPPERY and SURFACE_SLIPPERY defines have the same value, which is why this mistake is hard to notice.

    *  The firsty frames define was implemented poorly, not allowing for vanilla firsty behavior no matter what the values were set to. This has been reverted, while avoiding the UB in the original vanilla code.

    *  Removed the ledge grab changes that fix QSLGs and change the false ledgegrab define since Arceveti wanted to in his PR

    * Update version to 2.0.4 (HackerN64#515)

    * HackerSM64 2.0.5 (HackerN64#517)

    * Bugfix: race condition with accessing cleared audio memory pools

    * Bugfix: skyboxes access tiles out of range when looking straight down (HackerN64#518)

    * Vscode fixes (HackerN64#516)

    * Revert s32 angles and remove Angle typedef usage (HackerN64#529)

    * Fix some surface shadowing (HackerN64#531)

    * Delete rtc.h

    * Remove `wait_for_audio_frames()`

    Co-authored-by: thecozies <[email protected]>
    Co-authored-by: Arceveti <[email protected]>
    Co-authored-by: JoshDuMan <[email protected]>

    * Update VERSION.txt (HackerN64#534)

    * HackerSM64 2.0.6 (HackerN64#539)

    * revert random_u16 to be a u16 (HackerN64#538)

    * Added safety gcc math flags (HackerN64#537)

    * removed useless compilation flags that could cause performance loss

    Co-authored-by: thecozies <[email protected]>
    Co-authored-by: thecozies <[email protected]>

    * Update VERSION.txt

    HackerSM64 2.0.6

    * Add GCC opt flag to suppress warnings

    * v2.0.7

    * 2.0.8 (fix more compiler warnings) (HackerN64#543)

    * fix Waddress in mario_step.c

    * fix Winfinite-recursion in unused dynlist_proc function

    * in fact remove the offending function entirely

    * fix warnings in RNC decompress functions

    * update version

    * fix version in VERSION.txt

    premature on my part, will update it to 2.0.10 next time

    Co-authored-by: someone2639 <[email protected]>

    Co-authored-by: arthurtilly <[email protected]>
    Co-authored-by: axollyon <[email protected]>
    Co-authored-by: Gregory Heskett <[email protected]>
    Co-authored-by: thecozies <[email protected]>
    Co-authored-by: JoshDuMan <[email protected]>
    Co-authored-by: thecozies <[email protected]>
    Co-authored-by: Reonu <[email protected]>
    Co-authored-by: someone2639 <[email protected]>
    Co-authored-by: someone2639 <[email protected]>

commit f04a3ab
Author: Arceveti <[email protected]>
Date:   Sat Dec 10 15:25:53 2022 -0500

    Make JRB mist and DDD objects act-specific. (HackerN64#393)

    * Add JRB_ACT_SPECIFIC_MIST and DDD_ACT_SPECIFIC_OBJECTS

    * Disable the act-specific defines by default

    * Make act-specific objects/mist non-optional

    * Update JRB mist comment

    * Act-specific whirlpools + fix act 6 objects

    * Initialize gCurrActNum + revert formatting change

    * Use -1 for ALL_ACTS

    * Revert ALL_ACTS line

commit d028d6e
Author: Gregory Heskett <[email protected]>
Date:   Thu Dec 8 10:41:50 2022 -0500

    Bugfix: Save & Quit crashes game (HackerN64#548)

commit 22b3c9b
Author: Reonu <[email protected]>
Date:   Tue Dec 6 18:44:16 2022 +0100

    Fix 100 coin stars spawning inside ceilings + being able to spawn multiple 100 coin stars (HackerN64#541)

    * Going below 100 coins and getting 100 coins again will no longer result in multiple 100 coin stars spawning

    * 100 coin stars can no longer clip into ceilings

    * Renamed set_home_to_mario to spawned_star_set_target_above_mario since it's a more descriptive name of what it does

commit 1098ea9
Author: Arceveti <[email protected]>
Date:   Mon Nov 28 15:06:34 2022 -0500

    Merge master/2.0.5 into 2.1.0 (HackerN64#536)

    * Imminent fixes for bugs found on master branch (HackerN64#512)

    * The vanilla level checks define for Yoshi is inverted, causing him to require 120 stars when it is off and appear at 0 stars when it's on

    *  The downwarp fix results in Mario levitating in midair when grabbing Bowser midair. While downwarps should still be fixed, the change should be reverted immediately until a better fix is made.

    *  Some checks of Mario's floor class were using the wrong defines, which can lead to unexpected behavior in the event anyone wants to reorder surface types. By default the SURFACE_CLASS_SLIPPERY and SURFACE_SLIPPERY defines have the same value, which is why this mistake is hard to notice.

    *  The firsty frames define was implemented poorly, not allowing for vanilla firsty behavior no matter what the values were set to. This has been reverted, while avoiding the UB in the original vanilla code.

    *  Removed the ledge grab changes that fix QSLGs and change the false ledgegrab define since Arceveti wanted to in his PR

    * Update version to 2.0.4 (HackerN64#515)

    * HackerSM64 2.0.5 (HackerN64#517)

    * Bugfix: race condition with accessing cleared audio memory pools

    * Bugfix: skyboxes access tiles out of range when looking straight down (HackerN64#518)

    * Vscode fixes (HackerN64#516)

    * Revert s32 angles and remove Angle typedef usage (HackerN64#529)

    * Fix some surface shadowing (HackerN64#531)

    * Delete rtc.h

    * Remove `wait_for_audio_frames()`

    Co-authored-by: thecozies <[email protected]>
    Co-authored-by: Arceveti <[email protected]>
    Co-authored-by: JoshDuMan <[email protected]>

    * Update VERSION.txt (HackerN64#534)

    Co-authored-by: arthurtilly <[email protected]>
    Co-authored-by: axollyon <[email protected]>
    Co-authored-by: Gregory Heskett <[email protected]>
    Co-authored-by: thecozies <[email protected]>
    Co-authored-by: JoshDuMan <[email protected]>

commit 86841a3
Author: Reonu <[email protected]>
Date:   Tue Nov 8 17:08:45 2022 +0100

    Add super slippery surface type (HackerN64#422)

    * Added super slippery surface·

    * fix requested changes

    * add comment for forcing mario to belly slide

    * hi arthur

    * society

    * adress nitpick

    Co-authored-by: aglab2 <[email protected]>

commit 12b91fe
Author: Gregory Heskett <[email protected]>
Date:   Thu Nov 3 03:54:04 2022 -0400

    Disable DISABLE_ALL (HackerN64#528)

    Because literally who is gonna make a hack without ever using any debug features?

commit a42bd9b
Author: Gregory Heskett <[email protected]>
Date:   Thu Nov 3 03:52:19 2022 -0400

    Implemented native Gamecube controller support and corresponding emulator hint in ROM header (HackerN64#505)

    * Implemented native Gamecube controller support and corresponding emulator hint in ROM header

    * Added X and Y buttons to VALID_BUTTONS in sm64.h

    * Added workaround in controller type detection for mupen bug

    * read GC controllers from port 2

    * L to Z logic for GC controller uses a threshold

    * Changed threshold for L trig to around 33%

    Changed threshold based on feedback

    * Added gGamecubeControllerPort

    * fixed wrong check

    * Bugfix: Game crashes when less than 2 controllers are connected

    * Suppress compiler warnings

    * Bugfix: button swapping still takes place on non-GC controllers

    * Wrap port 2 stuff in console check

    aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa

    * GC console check

    * Funny emulator crash moment

    * block comment moment

    * Added centering for the gamecube controller, support reset command (HackerN64#511)

    * Added centering for the gamecube controller, support reset command

    * Use struct 'ControllerCenters' for 'gGamecubeControllerCenters'

    * Store gamecube controller centers per controller

    * Clamp GC controller stick values to s8

    * the

    formatting changes

    Co-authored-by: Mr-Wiseguy <[email protected]>
    Co-authored-by: Reonu <[email protected]>
    Co-authored-by: Denis Kopyrin <[email protected]>

commit a784c18
Author: Reonu <[email protected]>
Date:   Thu Nov 3 00:36:59 2022 +0100

    Wrap boulder room check under vanilla specific level checks (HackerN64#521)

commit 987f761
Author: Gregory Heskett <[email protected]>
Date:   Wed Nov 2 19:35:04 2022 -0400

    Bugfix: RCP has gone loud because SOMEONE didn't look at their compiler output (HackerN64#526)

commit 088dbbd
Author: Reonu <[email protected]>
Date:   Thu Nov 3 00:25:24 2022 +0100

    Make warp surfaces use the force parameter if set (HackerN64#525)

commit ab94fd7
Author: arthurtilly <[email protected]>
Date:   Thu Nov 3 11:35:47 2022 +1300

    Make objects not run their code if the room they are in isn't loaded. (HackerN64#502)

commit d7d0364
Author: Gregory Heskett <[email protected]>
Date:   Wed Nov 2 18:24:39 2022 -0400

    Add define to disable pitch shifting of Mario sound effects (HackerN64#522)

    * Add define to disable pitch shifting of Mario sound effects

    * Point new voice sequence macros to existing ones

    * Remove pitch shifting sequence macros from peach sounds

commit 38d3c82
Merge: a7a637e 4ae3a43
Author: Reonu <[email protected]>
Date:   Wed Nov 2 20:14:48 2022 +0100

    Merge pull request HackerN64#469 from someone2639/rcp_hung

    add scheduler entry for when RCP locks up (addresses HackerN64#344)

commit a7a637e
Author: Denis Kopyrin <[email protected]>
Date:   Thu Oct 20 01:57:53 2022 +0000

    Disable cache emulation checks for VC (HackerN64#509)

    * Disable cache emulation checks for VC

    * Get rid of unnecessary gIsVC initialization

commit fc6a605
Author: Gregory Heskett <[email protected]>
Date:   Wed Oct 19 12:38:58 2022 -0400

    Bugfix: WF stationary platforms given static collision despite being able to delete themselves (HackerN64#510)

    Resulted in a memory leak and stale object referencing that impacted Mario's positioning

commit 6291c77
Author: Gregory Heskett <[email protected]>
Date:   Tue Oct 4 23:56:10 2022 -0400

    Convert `oBehParams` to be unsigned, and fix `GLOBAL_STAR_IDS` to support more than 128 stars (HackerN64#503)

commit 68f09d3
Author: Gregory Heskett <[email protected]>
Date:   Mon Oct 3 19:06:53 2022 -0400

    Bugfix: Reset mario's room when switching areas (HackerN64#504)

    Mario's room sometimes is not reset when warping between different areas, generally when warping from one area with rooms to another without them. This can cause things like doors to not render properly.

commit 0dd3ef7
Author: Chasarr <[email protected]>
Date:   Sat Oct 1 00:54:07 2022 +0200

    Fix CROSS variable on multiple environments (HackerN64#483)

    The name of the compiler that CROSS is set to varies from system to
    system. (gcc-mips-linux-gnu on Debian) This was not handled in
    s2d_engine and calc_bss.sh

commit da4b4db
Author: Gregory Heskett <[email protected]>
Date:   Fri Sep 30 18:41:58 2022 -0400

    Bugfix: Change instant warps to use ints instead of shorts (HackerN64#500)

    Additionally clean up some inconsistencies surrounding instant warps

commit 8c56afd
Author: thecozies <[email protected]>
Date:   Fri Sep 30 17:40:50 2022 -0500

    Added ability to automatically pull unfloader and build for unf debug (HackerN64#462)

    `make unf` added: build rom then pull the unfloader binary if needed, then load rom in debug mode
    also, `make load` will pull unfloader as well!

commit 3d0be18
Author: Gregory Heskett <[email protected]>
Date:   Thu Sep 29 16:54:08 2022 -0400

    Bugfix: Memory leak caused by missing pool pop state (HackerN64#497)

commit 74730e7
Author: Reonu <[email protected]>
Date:   Thu Sep 29 21:52:22 2022 +0100

    Simplified lives defines (HackerN64#439)

    * Combined ENABLE_LIVES and DEFAULT_NUM_LIVES, and removed SAVE_NUM_LIVES

    * removed commented out lines

    * numLives no longer modified by default when lives are disabled

    This allows for the variable to be repurposed more easily

    * Remove SAVE_NUM_LIVES define

    * Remove SAVE_NUM_LIVES and DISABLE_LIVES define (Take 2)

    * Apply MAX_NUM_LIVES and MAX_NUM_COINS to update_hud_values()

    Co-authored-by: gheskett <[email protected]>

commit 1ef7329
Author: thecozies <[email protected]>
Date:   Thu Sep 29 15:50:49 2022 -0500

    Added WORLDSPACE_LIGHTING define (HackerN64#461)

    Co-authored-by: Gregory Heskett <[email protected]>

commit ebf19af
Author: Arceveti <[email protected]>
Date:   Wed Sep 28 12:21:06 2022 -0700

    Clean up a bit of code in file_select.c, fixing copy menu buttons not properly getting deleted when switching pages.

commit 8864e5f
Author: Gregory Heskett <[email protected]>
Date:   Thu Sep 22 07:30:02 2022 -0400

    Revert "Implemented native Gamecube controller support and corresponding emulator hint in ROM header (HackerN64#408)" (HackerN64#494)

    This reverts commit 4dfb8d9.

commit 4dfb8d9
Author: Mr-Wiseguy <[email protected]>
Date:   Wed Sep 21 22:30:36 2022 -0400

    Implemented native Gamecube controller support and corresponding emulator hint in ROM header (HackerN64#408)

    * Implemented native Gamecube controller support and corresponding emulator hint in ROM header

    * Added X and Y buttons to VALID_BUTTONS in sm64.h

    * Added workaround in controller type detection for mupen bug

    * read GC controllers from port 2

    * L to Z logic for GC controller uses a threshold

    * Changed threshold for L trig to around 33%

    Changed threshold based on feedback

    * Added gGamecubeControllerPort

    * fixed wrong check

    Co-authored-by: Reonu <[email protected]>

commit 6dbe379
Author: someone2639 <[email protected]>
Date:   Wed Sep 21 21:42:38 2022 -0400

    remove warnings from rnc1/2 files (HackerN64#468)

    Co-authored-by: someone2639 <[email protected]>

commit de34eb3
Author: thecozies <[email protected]>
Date:   Wed Sep 21 20:18:37 2022 -0500

    Remove redundant s2d directory and delete unused files/defines (HackerN64#457)

commit 2e701ad
Author: someone2639 <[email protected]>
Date:   Wed Sep 21 21:03:24 2022 -0400

    add error macro that will always fire (HackerN64#492)

    * add error macro that will always fire

    * add an aggress macro

    like an assert macro but more aggressive and independent of DEBUG being defined (gives us 3 crash reporting options)

    Co-authored-by: someone2639 <[email protected]>

commit 4ae3a43
Author: someone2639 <[email protected]>
Date:   Wed Sep 21 20:36:39 2022 -0400

    Use the error macro for rcp hang

commit c09f178
Author: thecozies <[email protected]>
Date:   Wed Sep 21 19:14:12 2022 -0500

    reverted geo bone (HackerN64#474)

commit d5019ff
Author: Tubular Bells <[email protected]>
Date:   Wed Sep 21 19:13:19 2022 -0500

    Clean up remaining DISABLE_LEVEL_CHECKS ifndefs (HackerN64#479)

commit 0583993
Author: Arceveti <[email protected]>
Date:   Wed Sep 21 17:10:41 2022 -0700

    Fix inverted null check in obj_get_model_id (HackerN64#484)

commit c0e00be
Author: Gregory Heskett <[email protected]>
Date:   Wed Sep 21 19:51:31 2022 -0400

    Sound effect tables now support up to 255 sounds instead of 128 (HackerN64#465)

commit 1af9f2b
Author: Tubular Bells <[email protected]>
Date:   Wed Sep 21 18:49:23 2022 -0500

    Restores dither effect on teleport (HackerN64#476)

commit ac45e70
Author: Tubular Bells <[email protected]>
Date:   Wed Sep 21 18:29:00 2022 -0500

    Restored exit course sound effect functionality independent of vanilla level check. (HackerN64#475)

    May be worth revisiting in the future to address the fact the exit course warp node will always trigger this sound effect, even when shared with other warps. Would potentially also be nice to add an option for using this sound effect with 0xF3 floor warps.

commit aa5df07
Author: Gregory Heskett <[email protected]>
Date:   Wed Sep 21 11:58:25 2022 -0400

    Add define for using JP red coin sound (HackerN64#489)

commit af0982e
Merge: b225c91 7d65799
Author: thecozies <[email protected]>
Date:   Wed Sep 21 10:56:46 2022 -0500

    Merge pull request HackerN64#491 from HackerN64/master

    Remove Wiseguy from codeowners file :( (HackerN64#490)

commit 7d65799
Author: Gregory Heskett <[email protected]>
Date:   Wed Sep 21 10:10:06 2022 -0400

    Remove Wiseguy from codeowners file :( (HackerN64#490)

    * Remove Wiseguy from codeowners file :(
    * Add ArcticJaguar725 as the primary CODEWOWNER for the moment

commit b225c91
Author: Reonu <[email protected]>
Date:   Tue Aug 9 17:08:49 2022 +0100

    fix level mesh not updating (HackerN64#477)

commit f65eb9a
Author: Tubular Bells <[email protected]>
Date:   Wed Aug 3 15:05:03 2022 -0500

    Reformat config comments (HackerN64#470)

commit 93fd414
Author: someone2639 <[email protected]>
Date:   Tue Jul 26 20:56:17 2022 -0400

    add scheduler entry for when RCP locks up

commit 98958df
Author: Gregory Heskett <[email protected]>
Date:   Sat Jul 23 16:56:18 2022 -0400

    Line endings for all text files now forced to \n instead of \r\n (HackerN64#464)

commit 77f4bec
Author: Reonu <[email protected]>
Date:   Fri Jul 22 15:20:29 2022 +0100

    Delete config_interaction.h (HackerN64#440)

commit 27ff45d
Author: Reonu <[email protected]>
Date:   Fri Jul 22 15:00:03 2022 +0100

    Replace unused 0C bank with aglab's / scut's extended 0C bank  (HackerN64#412)

commit 3149239
Author: Arceveti <[email protected]>
Date:   Fri Jul 22 06:58:17 2022 -0700

    Clean up gotos from find_wall_collisions_from_list (HackerN64#288)

commit a3e831d
Merge: 5b7b0ab a549e1a
Author: thecozies <[email protected]>
Date:   Tue Jul 19 12:22:10 2022 -0500

    Merge pull request HackerN64#456 from HackerN64/master

    Merge master into 2.1.0

commit a549e1a
Merge: 62d6ee1 83fea6d
Author: thecozies <[email protected]>
Date:   Tue Jul 19 11:44:14 2022 -0500

    Merge pull request HackerN64#454 from HackerN64/develop/2.0.3

    HackerSM64 2.0.3 Release: Audio Crash

commit 83fea6d
Author: thecozies <[email protected]>
Date:   Tue Jul 19 11:35:48 2022 -0500

    v2.0.3

commit 5b7b0ab
Author: Reonu <[email protected]>
Date:   Tue Jul 19 14:34:00 2022 +0100

    moved CASTLE_MUSIC_FIX into level specific checks (HackerN64#437)

commit 5a9b5a9
Author: Reonu <[email protected]>
Date:   Tue Jul 19 14:04:54 2022 +0100

    Mat Stack Fix

    * Implemented new lightweight CPU/RDP profiler
    * Added RSP profiling to the lightweight profiler
    * Added CPU audio to lightweight profiler
    * Changed lingering manual light struct definitions to gdSPDefLights1, made a dummy light for Koopa's pink shorts
    * Ran script to convert all light commands to lightcolor commands
    * Added define guards for the profiler
    * Wrote function for setting up global light direction in the frame
    * Moved camera matrix into projection stack
    * Corrected cameraToObject for the new matrix stack (fixes culling and sound)
    * Fixed billboarding with new matrix stack
    * Fixed shadows with new matrix stack
    * Fixed some areas where the game was previously extracting the camera matrix from various matrices
    * Restored vanilla light and env map directions under new matrix stack
    * Fix goddard crash
    * Fix geo_process_level_of_detail
    * Remove 'construct_float' from 'geo_process_level_of_detail'
    * Removed some accidentally added files
    * Removed unnecessary matrix multiplications in geo_process_object
    * Added fixlights script to build system for fixing custom assets and added option to disable it if needed
    * Fixed visual debug with new matstack and cleaned up visual debug code
    * Fixed handling of WORLD_SCALE in view matrix so it doesn't get cancelled out
    * Fixed clip planes not scaling based on WORLD_SCALE

    Co-authored-by: Mr-Wiseguy <[email protected]>
    Co-authored-by: Arceveti <[email protected]>
    Co-authored-by: thecozies <[email protected]>

commit 1820b14
Author: arthurtilly <[email protected]>
Date:   Tue Jul 19 23:24:16 2022 +1200

    Fixed memory leak between areas from automatic surface pool size (HackerN64#452)

    * fixed mem leak

    * Add comment to second pop

commit f4b13d4
Merge: f6bb8b5 6f6c055
Author: thecozies <[email protected]>
Date:   Tue Jul 19 06:19:25 2022 -0500

    Merge pull request HackerN64#431 from gheskett/gcc10-compiler-warning

    Suppress a gcc10 compiler warning for uninitialized variable

commit f6bb8b5
Author: Fazana <[email protected]>
Date:   Tue Jul 19 03:22:22 2022 +0100

    Clear only used dynamic cells (HackerN64#451)

    Clear only used dynamic cells

commit 8698cc0
Author: gheskett <[email protected]>
Date:   Fri Jul 15 00:25:18 2022 -0400

    Bugfix: patch_audio_bank crash (hopefully) resolved for good

commit 6f6c055
Author: gheskett <[email protected]>
Date:   Wed Jun 29 00:17:04 2022 -0400

    Suppress a gcc10 compiler warning for uninitialized variable
aglab2 pushed a commit to aglab2/HackerSM64 that referenced this pull request Dec 14, 2022
@Reonu @aglab2
Delete config_interaction.h (HackerN64#440)
71f2e1c
aglab2 pushed a commit to aglab2/HackerSM64 that referenced this pull request Mar 15, 2023
@Reonu @aglab2
Delete config_interaction.h (HackerN64#440)
182ecf1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arceveti Arceveti Arceveti approved these changes

@thecozies thecozies thecozies approved these changes

@Mr-Wiseguy Mr-Wiseguy Awaiting requested review from Mr-Wiseguy

Assignees

@Reonu Reonu

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

Remove config_interactions.h file, move the one define it has somewhere else
5 participants
@Reonu @arthurtilly @thecozies @Arceveti @gheskett