Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] yarn to npm #4904

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

yuki0410-dev
Copy link
Contributor

@yuki0410-dev yuki0410-dev commented Jun 17, 2024

Description: I suggest moving from yarn to npm.

Linked issue: -

Problem

Changes

  • Migrated package manager from yarn to npm.
    • Fixed Github Actions.
  • Removed unnecessary packages that were blocked due to yarn v1.
  • Organized the naming of npm scripts since there was no regularity in naming them.

Contribution checklist

  • I have followed the contributing guidelines.
  • I have added sufficient test coverage for my changes.
  • I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This pull request was not sent to the PullRequest network because the pull request is a draft.

@yuki0410-dev yuki0410-dev changed the title [Proposal] remove yarn [Proposal] yarn to npm Jun 17, 2024
@yuki0410-dev yuki0410-dev marked this pull request as ready for review June 17, 2024 15:03
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.39%. Comparing base (c550195) to head (84d808f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4904   +/-   ##
=======================================
  Coverage   96.39%   96.39%           
=======================================
  Files          28       28           
  Lines        3305     3305           
  Branches     1387     1400   +13     
=======================================
  Hits         3186     3186           
+ Misses        119      115    -4     
- Partials        0        4    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!

What to expect from this code review:
  • Comments posted to any areas of potential concern or improvement.
  • Detailed feedback or actions needed to resolve issues that are found.
  • Turnaround times vary, but we aim to be swift.

@yuki0410-dev you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 84
- 110

31% GitHubActions
23% JSON
22% Markdown
18% GitHubActions (tests)
6% Other

Generated lines of change

+ 92,081
- 26,420

Type of change

Feature - These changes are adding a new feature or improvement to existing code.


- name: Check Code Formatter
run: yarn prettier:check

- name: Type Check
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since type check by tsc is already performed at the time of rollup build and at the time of ts-jest execution, it is not necessary to perform it again here.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On its own, this change looks fine sans a formatting nit. However, changing from yarn to npm is a fairly significant change to be occurring without previous consensus on doing so. Personally, I don't see the need for it, particularly as there is a workaround that is already being used. However this decision is up to the HackerOne team.

Image of Jacob Jacob


Reviewed with ❤️ by PullRequest

README.md Show resolved Hide resolved
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found in this change, looks good to me.

Image of Jacques Jacques


Reviewed with ❤️ by PullRequest

@yuki0410-dev
Copy link
Contributor Author

yuki0410-dev commented Jun 17, 2024

However, changing from yarn to npm is a fairly significant change to be occurring without previous consensus on doing so.

I agree.
I created the PR as a suggestion, hoping that you would be able to judge from the specific changes!

Personally, I don't see the need for it, particularly as there is a workaround that is already being used.

There are some PACKAGES that cannot be deleted due to the use of YARN.
#4896

I have not had any problems at all with npm.

However this decision is up to the HackerOne team.

I think you are right.

@yuki0410-dev
Copy link
Contributor Author

@martijnrusschen
What do you think about this change?
We are willing to resolve conflicts if the policy seems acceptable.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest reviewed the updates made to #4904 since our last review was posted. This includes comments that have been posted by non-PullRequest reviewers. No further issues were found.

Reviewed by:

Image of Jacques Jacques

@yuki0410-dev
Copy link
Contributor Author

@martijnrusschen
Would it be possible to merge this PR conflict if I fix it?

@yuki0410-dev yuki0410-dev force-pushed the feat/remove-yarn branch 2 times, most recently from 967277e to ba68923 Compare July 5, 2024 14:10
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no issues with this change, looks good to me!

Image of Jacques Jacques


Reviewed with ❤️ by PullRequest

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to inactivity, PullRequest has cancelled this review job. You can reactivate the code review job from the PullRequest dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant