Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Sanity queries on resources page #101

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Conversation

samderanova
Copy link
Contributor

@samderanova samderanova commented Oct 29, 2023

I've created Sanity queries on the resource page to query for a specific type of resource (API, backend, frontend, etc.). I've also made some but not a lot of adjustments to the resources frontend to showcase how the properties provided by the schema should be used.

Some lingering issues that I think should be resolved in a separate issue:

  • We should simplify the cards, meaning only one reusable component should be used for all the cards, instead of having a different component for each section.
  • The description for the the backend resources overflows its index card background. This can be easily resolved by adding preserveAspectRatio="none" to the SVG of the index card.

@github-actions
Copy link

github-actions bot commented Oct 29, 2023

Deploy preview for zothacks-site-2023-sanity ready!

Name Sanity Studio
Preview Visit Preview
Commit 5d4524e

@github-actions
Copy link

github-actions bot commented Oct 29, 2023

Deploy preview for zothacks-site-2023 ready!

Name Hack at UCI Site
Preview Visit Preview
Commit 5d4524e

@samderanova samderanova linked an issue Oct 29, 2023 that may be closed by this pull request
Copy link
Contributor

@tyleryy tyleryy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add export const revalidate = 60; to the resource and schedule page.tsx. The pages don't update content on sanity changes.

Copy link
Contributor

@tyleryy tyleryy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tyleryy tyleryy merged commit 34c79a3 into main Oct 31, 2023
2 checks passed
@taesungh taesungh deleted the update/resources-sanity branch September 27, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resources Page: Set Up Sanity Queries
3 participants