Added Resources title and section title component #177
+102
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for zothacks-site-2023 ready!
|
|
Deploy preview for zothacks-site-2023-sanity ready!
|
waalbert
reviewed
Oct 9, 2024
waalbert
reviewed
Oct 9, 2024
waalbert
reviewed
Oct 9, 2024
|
|
||
| function Landing() { | ||
| return ( | ||
| <div className={styles.landing}> | ||
| <h1>Resources</h1> | ||
| <Image src={resourcesTitle} alt="resources title" /> |
There was a problem hiding this comment.
Issue: the size of the Resources Title stays the same for all screen sizes, so on small screens (i.e iPhone SE), the title starts getting cut off on the sides.
waalbert
reviewed
Oct 9, 2024
Comment on lines
+3
to
+4
| $item-padding-y: 32px; | ||
| $item-padding-x: 48px; |
There was a problem hiding this comment.
Thought: similar to the FAQs, on smaller screen sizes the text looks a bit squished.
waalbert
reviewed
Oct 10, 2024
| @@ -1,27 +1,26 @@ | |||
| import { PortableText } from "@portabletext/react"; | |||
| import { client } from "@/lib/sanity/client"; | |||
There was a problem hiding this comment.
Chore: client is defined in our own code, so where it was initially placed was correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #168 and #171.
Changed the section title in API Resources to show custom section title.
Go to the
/resourcesroute to see the changes