Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vllm.logger.init_logger dependency #53

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kzawora-intel
Copy link
Collaborator

@kzawora-intel kzawora-intel commented Dec 9, 2024

vLLM APIs change, as experienced in #52, and when they do, users might experience crashes on upstream. To avoid possible future import errors, we should import as little as possible from vLLM. Considering that current vLLM init_logger method looks as follows:

def init_logger(name: str) -> Logger:
    """The main purpose of this function is to ensure that loggers are
    retrieved in such a way that we can be sure the root vllm logger has
    already been configured."""

    return logging.getLogger(name)

There isn't really any reason not to interact with logging directly.

Copy link
Contributor

@michalkuligowski michalkuligowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please solve conflict in profiler.py file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants