Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix long contexts in LoRA #624

Open
wants to merge 4 commits into
base: habana_main
Choose a base branch
from

Conversation

SanjuCSudhakaran
Copy link

@SanjuCSudhakaran SanjuCSudhakaran commented Dec 12, 2024

#566 breaks long-contexts + LoRA flow.

This assumes caching sin-cos buffer for first decoder layer is sufficient to handle all cases, which is not the applicable for long-context + LoRA.

This PR ignores _prepare_cos_sin call prior to HpuModelAdapter forward in long-context + LoRA flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant