Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize for topk=1 case if we do not handle duplicates #603

Open
wants to merge 2 commits into
base: habana_main
Choose a base branch
from

Conversation

ssarkar2
Copy link

@ssarkar2 ssarkar2 commented Dec 9, 2024

Original : #599

We have a case where topk=1, and topp=<1.

Adding special handling for the case topk=1 and handle_duplicate=0 (by default handle_duplicate=0, to support num-scheduling-steps)

@kdamaszk
Copy link

@ssarkar2 please fix formatting

@ssarkar2
Copy link
Author

@ssarkar2 please fix formatting

done

@michalkuligowski michalkuligowski force-pushed the sarkar/topk1_ignoreduplicates_optimized branch from 91c1dfe to c6023de Compare December 12, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants