Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23 team #103

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

23 team #103

wants to merge 14 commits into from

Conversation

Verousca
Copy link
Collaborator

General Checks

  • the branch is up to date with main/master
  • the code works when pulled and run locally
  • All CI checks pass
  • all conflicts are resolved (if any)
  • PR has a descriptive title
  • PR has appropriate labels and milestones for easy identification
  • PR it is assigned to the owner
  • reviewers are assigned
  • the PR contributes only one focused change
  • It is in the appropriate column in the project board (if necessary)
  • has short and clear description
  • is linked to an issue (if it is related)
  • feedback is addressed (if any and if it is appropriate feedback.)

Markdown

  • the markdown source is formatted
  • spelling and grammar is correct in all text
  • The markdown looks correct when you preview the file
  • all links and images work

HTML

  • pages besides /index.html are stored in /pages
  • the code is well-formatted
  • the HTML is valid
  • there are no inline styles (example: style='color: red;')
  • there are no <style> tags with CSS, all styles are hrefs
  • there is no inline JavaScript (example: onclick='doSomething()')
  • there are no <script> tags with JS, all JS is in an separate file
  • ids are used for JavaScript only, not for CSS
  • semantic tags are used
  • spelling and grammar is correct in all site content

CSS

  • the code is well-formatted
  • passes all the linting checks

@Verousca Verousca added this to the html/css: week 2 milestone Aug 21, 2022
@Verousca Verousca self-assigned this Aug 21, 2022
@AzimaKai AzimaKai closed this Aug 22, 2022
@AzimaKai AzimaKai reopened this Aug 22, 2022
Copy link
Collaborator

@johnedelbi johnedelbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the name of all images to small letters and re-push your work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants