Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up issues spotted in #689 #693

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Tidy up issues spotted in #689 #693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af17bc9
Protection for missing configuration etc
EdwardMoyse Nov 8, 2024
a3883b9
Disable excessive pre-commit check
EdwardMoyse Oct 25, 2024
a62bc63
Update workflows to node v20
EdwardMoyse Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:

strategy:
matrix:
node-version: [18.x]
node-version: [20.x]

steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
npm run test:ci
#npm run test:ci

yarn lint-staged
2 changes: 1 addition & 1 deletion ...onents/lib/components/ui-menu/io-options/io-options-dialog/io-options-dialog.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ export class IOOptionsDialogComponent implements OnInit {

private getJiveXMLLoader(): JiveXMLLoader {
if (
this.eventDisplay.configuration.eventDataLoader instanceof JiveXMLLoader
this.eventDisplay?.configuration?.eventDataLoader instanceof JiveXMLLoader
) {
return this.eventDisplay.configuration.eventDataLoader as JiveXMLLoader;
} else {
Expand Down
Loading