Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cached versions of badges #1620

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Add cached versions of badges #1620

merged 1 commit into from
Nov 21, 2024

Conversation

graeme-a-stewart
Copy link
Member

When adding the HSF project badge to prmon I could not get the badge to work from a direct URL query to shields.io. Not clear why that happened as page previews of the README file worked fine.

This PR adds direct links to cached versions of the badges, which does seem to work correctly.

N.B. There will be a link checker failure, because referenced files do not exist until this PR is accepted.

@hegner
Copy link
Member

hegner commented Nov 21, 2024

Looks like a better solution

Copy link
Member

@eduardo-rodrigues eduardo-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that you managed to sort the "funny" issue so quickly 👍 !

@graeme-a-stewart graeme-a-stewart merged commit 6812e63 into main Nov 21, 2024
1 of 3 checks passed
@graeme-a-stewart graeme-a-stewart deleted the more-badges branch November 21, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants