Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.5.8 Changelog #116

Merged
merged 4 commits into from
May 22, 2024
Merged

3.5.8 Changelog #116

merged 4 commits into from
May 22, 2024

Conversation

burningtnt
Copy link
Member

No description provided.

@burningtnt burningtnt requested a review from zkitefly May 17, 2024 10:02
3gf8jv4dv
3gf8jv4dv reviewed May 17, 2024
View reviewed changes
Copy link
Contributor

@3gf8jv4dv 3gf8jv4dv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Credit for MCBBS restored in HMCL-dev/HMCL#2958. The related PR was written into the changelog when the relevant credit was removed before. Would you consider mentioning it this time?

3gf8jv4dv
3gf8jv4dv reviewed May 17, 2024
View reviewed changes
_changelog/stable.md Outdated Show resolved Hide resolved
@burningtnt
Copy link
Member Author

Credit for MCBBS restored in HMCL-dev/HMCL#2958. The related PR was written into the changelog when the relevant credit was removed before. Would you consider mentioning it this time?

For users who update there launcher frmo 3.5.7 to 3.5.8, the credit is never removed.

@3gf8jv4dv
Copy link
Contributor

3gf8jv4dv commented May 18, 2024 •
edited
Loading

For users who update there launcher frmo 3.5.7 to 3.5.8, the credit is never removed.

Maybe I did not make it clear enough. I mean, the related credits for MCBBS were indeed removed in 3.5.7 and mentioned in the changelog, while the related changes were partially restored in 3.5.8.

@burningtnt
Copy link
Member Author

Maybe I did not make it clear enough. I mean, the related credits for MCBBS were indeed removed in 3.5.7 and mentioned in the changelog, while the related changes were partially restored in 3.5.8.

My fault. My memory is wrong.

@burningtnt burningtnt requested a review from 3gf8jv4dv May 18, 2024 03:14
zkitefly
zkitefly reviewed May 18, 2024
View reviewed changes
_changelog/stable.md Outdated Show resolved Hide resolved
@zkitefly zkitefly merged commit 8058175 into main May 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkitefly zkitefly zkitefly approved these changes

@3gf8jv4dv 3gf8jv4dv 3gf8jv4dv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@burningtnt @3gf8jv4dv @zkitefly