Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to validate with sushi and ig publisher #151

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vadi2
Copy link

@vadi2 vadi2 commented Jun 22, 2024

Added validation to PRs and any commits to the master branch to ensure that only content that builds an IG successfully makes it in. This will help ensure that this IG doesn't get any broken builds.

Any QA errors or warnings will still be allowed though, and manual approval is necessary for it to run from forks on the first time.

Example of it working in fhircast-docs:

image

Let me know if there are any questions about this improvement! 🙂

@caspears
Copy link
Collaborator

I appreciate the submission. Please help me understand what this buys us. Commits to any branches on the HL7 Github automatically triggers a build with the results posted on Zulip, including the logs of the build (which is useful for troubleshooting). I assume the results of this validation would be made available after an attempted check-in in Github (though I am not familiar with this).
My concern is that we would be creating a workflow that is not generally adopted by HL7 and may cause confusion.
Perhaps this is a request that should be made the the FHIR-I Tooling team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants