Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toc fixes #736

Merged
merged 4 commits into from
Aug 22, 2023
Merged

Toc fixes #736

merged 4 commits into from
Aug 22, 2023

Conversation

lmckenzi
Copy link
Contributor

NOTE: Requires Grahame to push a change to the pubpack.

Copy link
Contributor

@grahamegrieve grahamegrieve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the changes to publisher.java?

@lmckenzi
Copy link
Contributor Author

lmckenzi commented Aug 15, 2023

The only thing changed is publisher.java - that's where the ToC is defined.

Presume you mean else if (defaultBusinessVersion != null && bc.getVersion()==null)?
That's because the prior code was failing when bc.getVersion() was null and throwing an null pointer exception.

@grahamegrieve
Copy link
Contributor

The correct fix is else if (defaultBusinessVersion != null && !bc.getVersionElement().isEmpty())

@lmckenzi
Copy link
Contributor Author

Fixed

Copy link
Contributor

@grahamegrieve grahamegrieve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@grahamegrieve grahamegrieve merged commit c32e056 into master Aug 22, 2023
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants