Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prod] Strip whitespace from beginning and end of string when creating RTR objectives, improve RSS feed processing, properly save source on RTR #2386

Merged
merged 14 commits into from
Sep 25, 2024

Conversation

thewatermethod
Copy link
Collaborator

Description of change

  • RTR goal form did not strip leading or trailing whitespace from objective titles. This can lead to unintentional duplicates
  • RTR goal form was incorrectly setting goal source in the frontend.
  • RSS feed processing uses a different approach that honors the markup and layout in confluence

How to test

  • Create a goal/objective on the RTR with extra space at the end of the objective. Use that goal/objective on the AR and confirm on the RTR that there is only one RTR
  • Set a goal with root causes/source on the RTR and save it. Confirm that you don't get an error.
  • View Confluence help drawers and confirm that the content is readable (it may need reworking to match initial design)

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@thewatermethod thewatermethod marked this pull request as ready for review September 25, 2024 13:37
@Jones-QuarteyDana Jones-QuarteyDana merged commit c1a699d into production Sep 25, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants