Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prod] Fix modal validation announcements #2364

Merged
merged 8 commits into from
Sep 12, 2024
Merged

Conversation

thewatermethod
Copy link
Collaborator

@thewatermethod thewatermethod commented Sep 12, 2024

Description of change

  • On the Goal Close/Suspend reason modal and the Objective close/suspend reason modal, the error message container needs to be in the document and have the text inserted on error rather than have the entire error container be dynamically inserted. Fixing this means that the error will be read properly to screenreaders.
  • On Safari, the side nav was displaying an extra set of left arrows because the standard browser styling wasn't properly hidden by our CSS. This PR fixes this.
  • The Goal Status Graph on the RTR seems to have been refactored to drop a needed accessibility feature (a readable version of the ratio of goals to status). I fixed this and improved the announcements for that graph overall

How to test

  • Confirm that the side nav for the site display appropriately on Safari and Chrome
  • Confirm that the "please select a reason" validation is read by screenreaders on the above mentioned modals
  • Confirm that the goal status graph is announced in a way that makes sense

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@thewatermethod thewatermethod marked this pull request as ready for review September 12, 2024 15:46
@Jones-QuarteyDana Jones-QuarteyDana merged commit 94af81e into production Sep 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants