Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prod] Quality of life & bug fixes for the TR import #2335

Merged
merged 15 commits into from
Aug 29, 2024
Merged

Conversation

thewatermethod
Copy link
Collaborator

@thewatermethod thewatermethod commented Aug 28, 2024

Description of change

Reviewing the import document with Traci & Heather and testing on my own, a few things came up which need to be adjusted.

  • Added loading overlay to CSV import as the lack of feedback was confusing
  • Cleaned up csvImport test
  • Fixed misnamed value in the event summary form
  • Correctly transformed audience value from CSV to match HTML expected value
  • Fixed "user does not exist" errors to print useful information
  • Cleaned up unused imports in NationalCenter service

TTAHUB-3315 also adds an additional query for use in the self serve data interface: monitoring-grant-citation-report.sql

How to test

Confirm the above. You can slack me for a CSV to use. The CSV does not import without error, but it demonstrates the above changes.

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@thewatermethod thewatermethod marked this pull request as ready for review August 29, 2024 12:55
@Jones-QuarteyDana Jones-QuarteyDana merged commit 48e912b into production Aug 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants