Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Prod] Minimize data flows when saving goals on the activity report, correct monitoring configuration, fix bug in create goals hook #2254

Merged
merged 19 commits into from
Jul 9, 2024
Merged

[Prod] Minimize data flows when saving goals on the activity report, correct monitoring configuration, fix bug in create goals hook #2254

merged 19 commits into from
Jul 9, 2024

Conversation

thewatermethod
Copy link
Collaborator

Description of change

  • Correct the monitoring config to get the correct columns
  • Explicitly define the data fields we need when saving goals from a report so that no extra information is passed
  • Fix a bug in the create goals hook

How to test

All changes are invisible to the UI, as long as saving goals still works from an activity report

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

nvms and others added 19 commits July 2, 2024 09:41
@nvms
fix bug, cover with test
0ec7503
@nvms
fix the fix, update tests
48f5082
@dependabot
Bump ws from 8.5.0 to 8.17.1
475b57c 
Bumps [ws](https://github.com/websockets/ws) from 8.5.0 to 8.17.1.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@8.5.0...8.17.1)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@nvms
Merge pull request #2247 from HHS/jp/3115/bugfix
bccfb98 
[TTAHUB-3115] Fix bug in createGoalsForSessionRecipientsIfNecessary
@dependabot
Merge pull request #2249 from HHS/dependabot/npm_and_yarn/ws-8.17.1
8e4bbc8
@GarrettEHill
Create 20240702000000-monitoring-config-correction.js
9206b6d
@GarrettEHill
Update record.ts
6aac891
@thewatermethod
Minimize data flow between the frontend and backend
affe7bd
@GarrettEHill
Update record.test.js
7c132cd
@GarrettEHill
Update record.test.js
666b3f7
@GarrettEHill
Update record.test.js
61d44d6
@GarrettEHill
Update record.test.js
493ec28
@GarrettEHill
Update record.test.js
101f88e
@GarrettEHill
Update testUtils.js
cdd3758
@GarrettEHill
fixing tests
bffc080
@GarrettEHill
Update record.test.js
418b908
@GarrettEHill
Merge pull request #2250 from HHS/TTAHUB-3125/monitoring-config-corre…
23b0303 
…ction

[TTAHUB-3125] Monitoring Data Issue
@thewatermethod
Still include ID for keying purposes
e56a47e
@thewatermethod
Merge pull request #2251 from HHS/mb/TTAHUB-3109/minimize-data-flow
a7c685b 
Minimize data flow between the frontend and backend (activity report -> goals)
@thewatermethod thewatermethod marked this pull request as ready for review July 9, 2024 13:52
@Jones-QuarteyDana Jones-QuarteyDana merged commit b9bf534 into production Jul 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jones-QuarteyDana Jones-QuarteyDana Jones-QuarteyDana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thewatermethod @Jones-QuarteyDana @nvms @GarrettEHill