Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prod] Remove fields from the objective form on the RTR #2167

Merged
merged 99 commits into from
May 29, 2024

Conversation

thewatermethod
Copy link
Collaborator

@thewatermethod thewatermethod commented May 28, 2024

Description of change

Removes objective sub-fields from the RTR and adjusts the Activity report form accordingly (see attached video)

Screen.Recording.2024-05-28.at.2.56.13.PM.mov

PR also includes two data fixes: one for the non-UTF-8 characters that were imported to the courses and the other to save historical root causes on multi-recipient reports, which were not cached originally.

We also add a SQL file to the repository, which can be used to generate a report at a later date.

How to test

Confirm that:

  • Objective fields resources, topics, support type, courses, and files have been removed from the RTR
  • On the RTR, text is editable until the objective was used on a report
  • On the RTR, goal source is editable until goal is on an approved report
  • On the AR, objective text is only editable if created on a report
  • On the AR, goal source is editable until goal is on an approved report

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

thewatermethod and others added 26 commits May 24, 2024 10:40
…ses_on_ars

[TTAHUB-2560] dedupe ARG and create timeseries functions, restore missing ARGFRs
…names

[TTAHUB-2986]Correct Spanish coursenames with unknown characters
…B-2660/activity-report-updates-for-reduced-objectives
…tes-for-reduced-objectives

[TTAHUB-2260] Activity report updates for reduced objective fields
[TTAHUB-2999] Create monthly-delivery-report.sql
…-form

[TTAHUB-2530] Remove fields from objective form in RTR
@thewatermethod thewatermethod marked this pull request as ready for review May 28, 2024 20:25
@Jones-QuarteyDana Jones-QuarteyDana merged commit 5d6b8d5 into production May 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants