Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prod] Don't separate goals by status on the AR. #2165

Merged
merged 4 commits into from
May 24, 2024
Merged

Conversation

thewatermethod
Copy link
Collaborator

@thewatermethod thewatermethod commented May 24, 2024

Description of change

There is an ongoing bug where goals are separated by status on an Activity report. We've made many changes to how goal status is managed in the past months. For one, status is no longer editable on a report. We've also removed draft, closed, and suspended goals as options, and goals are moved from not started to in progress automatically. I don't think we need to separate them anymore.

Doing so also resolves this support case, where it is impossible to remove a phantom objective from a report.

How to test

Use the new bin/latest_backup.sh script to download a copy of prod.
Impersonate the user in the video linked in the Jira ticket.
Remove the phantom objective from her report and confirm that it stays gone.

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@thewatermethod thewatermethod marked this pull request as ready for review May 24, 2024 18:44
@Jones-QuarteyDana Jones-QuarteyDana merged commit b648796 into production May 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants