Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROD] 05/13 [TTAHUB-2830] Message for CSV import [TTAHUB-2889] Save AR FEI root causes in cache [TTAHUB-2895] Update edit goal permissions #2146

Merged
merged 188 commits into from
May 14, 2024

Conversation

AdamAdHocTeam
Copy link
Collaborator

@AdamAdHocTeam AdamAdHocTeam commented May 13, 2024

Description of change

TTAHUB-2830: User receives an error message when trying to import a CSV file that is NOT UTF-8 format.
TTAHUB-2857: Prevent closing goals with open objectives
TTAHUB-2794: Cleanup: remove all the now-unused columns from the Goals table.
TTAHUB-2609/2610: Rearrange iPD course selection in activity report and session report forms
TTAHUB-2889: Saving a multi recipient AR with an FEI goal saves the cache.
TTAHUB-2895: Edit goal only show for users with read/write permission.

How to test

TTAHUB-2830: User receives an error message when trying to import a CSV file that is NOT UTF-8 format.
TTAHUB-2794: Cleanup: remove all the now-unused columns from the Goals table.
TTAHUB-2889: Saving a multi recipient AR with an FEI goal saves the cache.
TTAHUB-2895: Edit goal only show for users with read/write permission.

TTAHUB-2857

  • Attempt to close a goal with an open objective
  • Confirm that you can change objective status via the RTR card
  • Confirm that suspending goals & objectives work as expected from the RTR

TTAHUB-2609/2610

Confirm the following is true:

  • On the course selector (session report and activity report forms use the same component), add "Other" as option for iPD course name.
  • Sort order for iPD course names in alphabetical order except for "Other". "Other" is at the end of the course name list.
  • Move iPD radio button above "Link to TTA resource" radio buttons.
  • Change "Link to TTA resource" to "Did you use any other TTA resources that are available as a link ?"
  • Change "Did you use any TTA resources that aren't available as a link ?" to "Did you use any other TTA resources that are available as a link ?"

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

dependabot bot and others added 30 commits April 25, 2024 05:06
Bumps [pydantic](https://github.com/pydantic/pydantic) from 2.1.1 to 2.4.0.
- [Release notes](https://github.com/pydantic/pydantic/releases)
- [Changelog](https://github.com/pydantic/pydantic/blob/main/HISTORY.md)
- [Commits](pydantic/pydantic@v2.1.1...v2.4.0)

---
updated-dependencies:
- dependency-name: pydantic
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [ejs](https://github.com/mde/ejs) from 3.1.8 to 3.1.10.
- [Release notes](https://github.com/mde/ejs/releases)
- [Commits](mde/ejs@v3.1.8...v3.1.10)

---
updated-dependencies:
- dependency-name: ejs
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@AdamAdHocTeam AdamAdHocTeam marked this pull request as draft May 13, 2024 15:41
@AdamAdHocTeam AdamAdHocTeam changed the title [PROD] 05/13 [TTAHUB-2830] Message for CSV import [PROD] 05/13 [TTAHUB-2830] Message for CSV import [TTAHUB-2889] Save AR FEI root causes in cache [TTAHUB-2895] Update edit goal permissions May 14, 2024
@thewatermethod thewatermethod marked this pull request as ready for review May 14, 2024 20:04
@Jones-QuarteyDana Jones-QuarteyDana merged commit c2fdbe0 into production May 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants