Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prod] Reopen closed goals, properly match goals with no collaborators, fix bug with goal similarity versioning #2112

Merged
merged 56 commits into from
Apr 23, 2024

Conversation

thewatermethod
Copy link
Collaborator

@thewatermethod thewatermethod commented Apr 23, 2024

Description of change

  • Allow reopening of closed goals from the RTR
  • If two goals have no collaborator, treat them as having the same collaborator
  • Fix bug with support feature flag where "closed_merge_goal_override" was not properly including closed FEI goals for support engineers

How to test

Go to the RTR and test reopening goal. Assert that the UI works without issue.

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@thewatermethod thewatermethod marked this pull request as ready for review April 23, 2024 13:55
@Jones-QuarteyDana Jones-QuarteyDana merged commit 54e7749 into production Apr 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants