Changes for the merge operations #26

kamalchowdhurylbl · 2022-08-10T21:42:43Z

No description provided.

kamalchowdhurylbl · 2022-08-10T22:33:55Z

changes in the vol_async file

houjun · 2022-08-11T16:58:05Z

src/h5_async_vol.c

@@ -1,5 +1,5 @@
 /*******************************************************************************
-Asynchronous I/O VOL Connector (AsyncVOL) Copyright (c) 2021, The
+Asynchronous I/O VOL kamal Connector (AsyncVOL) Copyright (c) 2021, The


reverse this change / remove your name

houjun · 2022-08-11T16:58:24Z

src/h5_async_vol.c

@@ -65,7 +65,7 @@ works, and perform publicly and display publicly, and to permit others to do so.
 /* Whether to display log messge when callback is invoked */
 /* (Uncomment to enable) */
 /* #define ENABLE_DBG_MSG 1 */
-/* #define PRINT_ERROR_STACK           1 */
+#define PRINT_ERROR_STACK 1


reverse this change

houjun · 2022-08-11T16:59:34Z

src/h5_async_vol.c

-    bool          disable_implicit_file;  /* Disable implicit async execution globally */
-    bool          disable_implicit;       /* Disable implicit async execution for dxpl */
-    bool          delay_time_env;         /* Flag that indicates the delay time is set by env variable */
-    bool          disable_async_dset_get; /* Disable async execution for dataset get */


add disable_async_dset_get line back

houjun · 2022-08-11T16:59:51Z

src/h5_async_vol.c

@@ -256,8 +256,9 @@ typedef struct async_attr_write_args_t {
    void * buf;
    hid_t  dxpl_id;
    void **req;
+


remove empty line

houjun · 2022-08-11T17:00:07Z

src/h5_async_vol.c

@@ -331,8 +332,9 @@ typedef struct async_dataset_write_args_t {
    hid_t  plist_id;
    void * buf;
    void **req;
+


remove empty line

houjun · 2022-08-11T17:07:19Z

test/2d_asyn_MPI_write.c

+        \n",offset_out[0],offset_out[1],count_out[0],count_out[1]);
+
+        status = H5Dwrite_async (dataset, H5T_NATIVE_INT, memspace, dataspace, data_transfer_propertylist,
+        data,es_id);


Are these commented out code useful? If not, remove them.

houjun · 2022-08-11T17:07:39Z

test/3d_asyn_MPI_write.c

+         {1,1,4,2,2,2}
+        }
+
+     };  */


Are these commented out code useful? If not, remove them.

houjun · 2022-08-11T17:07:50Z

test/3d_asyn_MPI_write.c

+    data,es_id);
+
+
+                    } */


Are these commented out code useful? If not, remove them.

houjun · 2022-08-12T17:11:57Z

test/Makefile

@@ -37,7 +37,8 @@ SRC = async_test_serial.c async_test_serial2.c \
    async_test_parallel.c async_test_parallel2.c async_test_parallel3.c \
    async_test_parallel4.c async_test_parallel5.c \
    async_test_serial_event_set.c async_test_serial_error_stack.c \
-    async_test_serial_event_set_error_stack.c
+    async_test_serial_event_set_error_stack.c 1d_asyn_MPI_write.c 2d_asyn_MPI_write.c \    
+    3d_asyn_MPI_write.c 1d_async_write_performance


1d_async_write_performance -> 1d_async_write_performance.c

houjun · 2022-08-12T17:14:07Z

src/h5_async_vol.c


+    if (return_val == 1)
+        goto done; 


add #ifdef ENABLE_WRITE_MERGE ... #endif before 9973 and after 9977, so that the merge only happens when enabled at compile time

houjun · 2022-08-12T17:32:19Z

src/h5_async_vol.c

@@ -1,5 +1,5 @@
 /*******************************************************************************
-Asynchronous I/O VOL Connector (AsyncVOL) Copyright (c) 2021, The
+Asynchronous I/O VOL  Connector (AsyncVOL) Copyright (c) 2021, The


remove the extra space

houjun · 2022-08-12T17:32:41Z

src/h5_async_vol.c

@@ -65,7 +65,7 @@ works, and perform publicly and display publicly, and to permit others to do so.
 /* Whether to display log messge when callback is invoked */
 /* (Uncomment to enable) */
 /* #define ENABLE_DBG_MSG 1 */
-/* #define PRINT_ERROR_STACK           1 */
+ #define PRINT_ERROR_STACK           1 


revert to commented line

houjun · 2022-08-25T21:01:21Z

src/Makefile

@@ -15,7 +15,7 @@ ABT_LIBDIR =  $(shell if [ -d $$ABT_DIR/lib ]; then echo "lib"; else echo "lib64

 # These lines may need to be adjusted for your compiler environment:
 DEBUG = -g -O0 
-CFLAGS = $(DEBUG) -fPIC -I$(ABT_DIR)/include -I$(HDF5_DIR)/include -Wall
+CFLAGS = $(DEBUG) -fPIC -I$(ABT_DIR)/include -I$(HDF5_DIR)/include -Wall -DENABLE_WRITE_MERGE


remove "-DENABLE_WRITE_MERGE", it should not be enabled by default

houjun

@kamalchowdhurylbl Please rerun the clang-format tool with "clang-format -i -style=file ./*.c", there are too many formatting changes with your latest commit.

houjun · 2022-08-29T22:16:25Z

src/Makefile

@@ -15,7 +15,7 @@ ABT_LIBDIR =  $(shell if [ -d $$ABT_DIR/lib ]; then echo "lib"; else echo "lib64

 # These lines may need to be adjusted for your compiler environment:
 DEBUG = -g -O0 
-CFLAGS = $(DEBUG) -fPIC -I$(ABT_DIR)/include -I$(HDF5_DIR)/include -Wall
+CFLAGS = $(DEBUG) -fPIC -I$(ABT_DIR)/include -I$(HDF5_DIR)/include -Wall -DENABLE_WRITE_MERGE


-DENABLE_WRITE_MERGE should be removed/commented out to not turn on the merge feature by default, until we do more testing

houjun · 2022-08-29T22:18:11Z

src/h5_async_vol.c

@@ -105,7 +105,7 @@ FILE *fout_g;
 /* The async VOL wrapper context */
 typedef struct H5VL_async_wrap_ctx_t {
    hid_t                under_vol_id;   /* VOL ID for under VOL */
-    void *               under_wrap_ctx; /* Object wrapping context for under VOL */
+    void                *under_wrap_ctx; /* Object wrapping context for under VOL */


You need to use the https://github.com/hpc-io/vol-async/blob/develop/.clang-format file when you run clang-format command, e.g. under vol-async/src do "clang-format -i -style=file ./*.c"

brtnfld · 2024-05-31T14:58:21Z

@houjun , do you know the status of this PR? Was it just a matter of format changes? Should we sync it with develop and format it?

houjun · 2024-05-31T16:29:30Z

@brtnfld, this is not ready to merge yet, I'll change it to a draft.

kamalchowdhurylbl and others added 11 commits August 9, 2022 21:17

added async vol file

8798b00

Committing clang-format changes

55dc459

Create 1d_asyn_MPI_write.c

359a229

Committing clang-format changes

e05fcad

Added 2d_asyn_MPI_write.c, 3d_asyn_MPI_write.c

5801426

added 1d_async_write_performance.c

6c8e635

Committing clang-format changes

751ac29

added changes in the vol async, 1d,2d,3d test files

7a22105

added vol async.c

02f6fc8

added 1d,2d, and 3d test files

42850a4

changes in the h5_async_vol.c

0f32b47

kamalchowdhurylbl added 2 commits August 11, 2022 14:41

added modified h5_async_vol.c

bcb93b2

changes in the makefile

8b77076

houjun reviewed Aug 12, 2022

View reviewed changes

kamalchowdhurylbl added 5 commits August 12, 2022 12:49

changes after review async vol.c

2243c14

changes after review async vol.c, 1d,2d,and 3d test write code

1aca595

changes after review async vol.c

32872ac

changes after review async vol.c,test 1d,2d and 3d, makefile

f48d330

added async vol.c with merge, and makefile

e524cb7

houjun reviewed Aug 25, 2022

View reviewed changes

houjun requested changes Aug 29, 2022

View reviewed changes

houjun marked this pull request as draft May 31, 2024 16:29

houjun self-assigned this May 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changes for the merge operations #26

Changes for the merge operations #26

kamalchowdhurylbl commented Aug 10, 2022

kamalchowdhurylbl commented Aug 10, 2022

houjun Aug 11, 2022

houjun Aug 11, 2022

houjun Aug 11, 2022

houjun Aug 11, 2022

houjun Aug 11, 2022

houjun Aug 11, 2022

houjun Aug 11, 2022

houjun Aug 11, 2022

houjun Aug 12, 2022

houjun Aug 12, 2022

houjun Aug 12, 2022

houjun Aug 12, 2022

houjun Aug 25, 2022

houjun left a comment

houjun Aug 29, 2022

houjun Aug 29, 2022

brtnfld commented May 31, 2024

houjun commented May 31, 2024

Changes for the merge operations #26

Are you sure you want to change the base?

Changes for the merge operations #26

Conversation

kamalchowdhurylbl commented Aug 10, 2022

kamalchowdhurylbl commented Aug 10, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

houjun left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brtnfld commented May 31, 2024

houjun commented May 31, 2024