-
-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for broken links in Doxygen generated html docs #5138
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add link check workflow
.github/workflows/main-cmake.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would be better served by a dedicated workflow that just needs to configure and build on one platform then having it check on all the systems. After all the links don't change between platforms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also nothing in CMake tests finished because the Macs claim to not know about the command.
You could use the first 65 lines of the netcdf.yml file for the configure and build and then add the link check. |
Could you add one more thing - put the actual linkcheck into a separate step
Change to:
It would be easier to focus on the actual issues rather then scrolling through the build stuff. |
This PR will report 36 broken links.
CI will fail until they are all fixed.
close #4928