Integrate API tests with testing framework #5133
Conversation
jhendersonHDF
added
Priority - 1. High 🔼
jhendersonHDF
requested review from
lrknox,
derobins,
byrnHDF,
fortnern,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
| @@ -403,10 +403,6 @@ if (HDF5_EXPORTED_TARGETS AND HDF5_TEST_API_INSTALL) | |||
|
|
|||
| foreach (api_test_extra ${HDF5_API_TESTS_EXTRA}) | |||
| if (TARGET ${api_test_extra}) | |||
| set_target_properties (${api_test_extra} | |||
| PROPERTIES | |||
| OUTPUT_NAME "h5_api_test_${api_test_extra}" | |||
There was a problem hiding this comment.
Reverts the renaming of the testhdf5 executable when HDF5_TEST_API_INSTALL is ON since this caused issues
| @@ -4002,13 +3936,6 @@ test_dataset_property_lists(void) | |||
| goto error; | |||
| } | |||
|
|
|||
| /** for DAOS VOL, this test is problematic since auto chunking can be selected, so skip for now */ | |||
| if (H5VLget_connector_name(file_id, vol_name, 5) < 0) { | |||
There was a problem hiding this comment.
With these changes we should be able to skip tests that are problematic for particular VOL connectors
jhendersonHDF
force-pushed
the
feature/api_tests_refactor
branch
from
db94aed
to
317942c
Compare
Allows skipping of individual tests by interface or by name
jhendersonHDF
force-pushed
the
feature/api_tests_refactor
branch
from
f326f1c
to
9b2480f
Compare
| @@ -11531,19 +11427,6 @@ test_dataset_set_extent_invalid_params(void) | |||
| goto error; | |||
| } | |||
|
|
|||
| /** for DAOS VOL, this test is problematic since auto chunking can be selected, so skip for now */ | |||
| if (H5VLget_connector_name(file_id, vol_name, 5) < 0) { | |||
There was a problem hiding this comment.
I'm guessing this was removed because this test can now be skipped during DAOS testing at runtime?
There was a problem hiding this comment.
Yes, I believe my thinking at the time was that it's not really necessary to have VOL-specific hacks in the code (I don't like these anyway) since this PR allows us to have more fine-grained control over skipping particular tests.
| { | ||
| char file_name[64]; | ||
| int i; | ||
|
|
||
| if (MAINPROCESS) { | ||
| H5Fdelete(PAR_ASYNC_API_TEST_FILE, H5P_DEFAULT); | ||
| remove_test_file(NULL, PAR_ASYNC_API_TEST_FILE); |
There was a problem hiding this comment.
Creation of this file is skipped based on VOL cap flags, so cleanup probably should be too
There was a problem hiding this comment.
True, though file cleanup should assume that some files may be missing anyway, so it's simpler and less code just to always try deleting things.
| { | ||
| char file_name[64]; | ||
| int i; | ||
| if (GetTestCleanup()) { |
There was a problem hiding this comment.
Cleanup check is redundant since remove_test_file also checks this
|
|
||
| remove_test_file(NULL, ASYNC_API_TEST_FILE); | ||
| remove_test_file(NULL, ASYNC_API_TEST_FILE); |
There was a problem hiding this comment.
Creation of this file is skipped based on VOL cap flags, so cleanup probably should be too
Allows skipping of individual tests by interface or by name